Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: "H.J. Lu" <hongjiu.lu@intel.com>, GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Check bfd_mach_x64_32 to set tdesc for x32 binary
Date: Sat, 12 May 2012 01:38:00 -0000	[thread overview]
Message-ID: <4FADBEED.4030704@codesourcery.com> (raw)
In-Reply-To: <20120511192949.GA5070@intel.com>

On 05/12/2012 03:29 AM, H.J. Lu wrote:
> Hi,
> 
> This patch checks bfd_mach_x64_32 to set tdesc for x32 binary.  Tested
> on Linux/x86-64.  OK to install?
> 
> Thanks.
> 
> 
> H.J.
> ---
> 	* amd64-linux-tdep.c: Include features/i386/x32-linux.c
> 	and features/i386/x32-avx-linux.c.

You committed this part first, and cause a build failure on x86_64.

cc1: warnings being treated as errors
/home/yqi/source/gdb/cvs_write/src/gdb/features/i386/x32-linux.c:10:
error: 'initialize_tdesc_x32_linux' defined but not used
/home/yqi/source/gdb/cvs_write/src/gdb/features/i386/x32-avx-linux.c:10:
error: 'initialize_tdesc_x32_avx_linux' defined but not used

-- 
Yao (齐尧)


      parent reply	other threads:[~2012-05-12  1:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 19:30 H.J. Lu
2012-05-11 20:20 ` Mark Kettenis
2012-05-11 23:13   ` H.J. Lu
2012-05-14 18:10     ` H.J. Lu
2012-05-14 18:42     ` Mark Kettenis
2012-05-14 19:02       ` H.J. Lu
2012-05-11 20:31 ` Mark Kettenis
2012-05-11 20:56   ` H.J. Lu
2012-05-12  1:38 ` Yao Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FADBEED.4030704@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=hongjiu.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox