From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25801 invoked by alias); 12 May 2012 01:38:25 -0000 Received: (qmail 25791 invoked by uid 22791); 12 May 2012 01:38:24 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_AV X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 12 May 2012 01:38:01 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1ST1HU-0006LU-6U from Yao_Qi@mentor.com ; Fri, 11 May 2012 18:38:00 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 11 May 2012 18:37:59 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Fri, 11 May 2012 18:37:20 -0700 Message-ID: <4FADBEED.4030704@codesourcery.com> Date: Sat, 12 May 2012 01:38:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: "H.J. Lu" CC: "H.J. Lu" , GDB Subject: Re: PATCH: Check bfd_mach_x64_32 to set tdesc for x32 binary References: <20120511192949.GA5070@intel.com> In-Reply-To: <20120511192949.GA5070@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00465.txt.bz2 On 05/12/2012 03:29 AM, H.J. Lu wrote: > Hi, > > This patch checks bfd_mach_x64_32 to set tdesc for x32 binary. Tested > on Linux/x86-64. OK to install? > > Thanks. > > > H.J. > --- > * amd64-linux-tdep.c: Include features/i386/x32-linux.c > and features/i386/x32-avx-linux.c. You committed this part first, and cause a build failure on x86_64. cc1: warnings being treated as errors /home/yqi/source/gdb/cvs_write/src/gdb/features/i386/x32-linux.c:10: error: 'initialize_tdesc_x32_linux' defined but not used /home/yqi/source/gdb/cvs_write/src/gdb/features/i386/x32-avx-linux.c:10: error: 'initialize_tdesc_x32_avx_linux' defined but not used -- Yao (齐尧)