Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH] Unbreak program transformation name `configure' options
Date: Fri, 27 Apr 2012 15:38:00 -0000	[thread overview]
Message-ID: <4F9ABD4C.9010406@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1204270700550.19835@tp.orcam.me.uk>

On 04/27/2012 04:15 PM, Maciej W. Rozycki wrote:

> Hi,
> 
>  This commit:
> 
> 2012-04-19  Pedro Alves  <palves@redhat.com>
> 
> 	gdb/
> 	* configure.ac: Remove gl_EARLY, gl_INIT and AM_INIT_AUTOMAKE
> 	calls.  Configure gnulib using ACX_CONFIGURE_DIR.
> 
> removed the handling of the program transformation name `configure' 
> options in this subdirectory (that was pulled implicitly with 
> AM_INIT_AUTOMAKE).
> 
>  OK to check in the following fix that reinstates it?


Yes, thanks.

I should have remembered to look at 9c9eabcbe003d635d12d43b5a926d7c01c2f5928 ,
the patch that originally added gnulib.

2008-04-14  Daniel Jacobowitz  <dan@codesourcery.com>

        * Makefile.in (LIBGNU, INCGNU): Define.
        (INTERNAL_CFLAGS_BASE): Add INCGNU.
        (INTERNAL_LIBS, CLIBS, CDEPS): Add LIBGNU.
        (CLEANDIRS): New.
        ($(LIBGNU), all-lib): New rules.
        (clean, distclean, do-maintainer-clean): Use CLEANDIRS.
        * configure.ac: Use gl_EARLY, gl_INIT, and AM_INIT_AUTOMAKE.
        Simplify AC_CONFIG_AUX_DIR.  Generate gnulib/Makefile.
        * gnulib: New directory, from gnulib-tool.
        * configure, aclocal.m4: Regenerated.

It indeed removed AC_ARG_PROGRAM.  It also does this though:

-AC_CONFIG_AUX_DIR(`cd $srcdir;pwd`/..)
+AC_CONFIG_AUX_DIR(..)

I wonder if we need to restore that bit as well.

-- 
Pedro Alves


  parent reply	other threads:[~2012-04-27 15:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-27 15:23 Maciej W. Rozycki
2012-04-27 15:37 ` Tom Tromey
2012-04-27 15:38 ` Pedro Alves [this message]
2012-04-27 15:50   ` Maciej W. Rozycki
2012-04-27 16:49     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9ABD4C.9010406@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox