From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11924 invoked by alias); 27 Apr 2012 15:38:06 -0000 Received: (qmail 11915 invoked by uid 22791); 27 Apr 2012 15:38:06 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 15:37:53 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3RFboKW004487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 Apr 2012 11:37:50 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q3RFbmfH019158; Fri, 27 Apr 2012 11:37:49 -0400 Message-ID: <4F9ABD4C.9010406@redhat.com> Date: Fri, 27 Apr 2012 15:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH] Unbreak program transformation name `configure' options References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg01000.txt.bz2 On 04/27/2012 04:15 PM, Maciej W. Rozycki wrote: > Hi, > > This commit: > > 2012-04-19 Pedro Alves > > gdb/ > * configure.ac: Remove gl_EARLY, gl_INIT and AM_INIT_AUTOMAKE > calls. Configure gnulib using ACX_CONFIGURE_DIR. > > removed the handling of the program transformation name `configure' > options in this subdirectory (that was pulled implicitly with > AM_INIT_AUTOMAKE). > > OK to check in the following fix that reinstates it? Yes, thanks. I should have remembered to look at 9c9eabcbe003d635d12d43b5a926d7c01c2f5928 , the patch that originally added gnulib. 2008-04-14 Daniel Jacobowitz * Makefile.in (LIBGNU, INCGNU): Define. (INTERNAL_CFLAGS_BASE): Add INCGNU. (INTERNAL_LIBS, CLIBS, CDEPS): Add LIBGNU. (CLEANDIRS): New. ($(LIBGNU), all-lib): New rules. (clean, distclean, do-maintainer-clean): Use CLEANDIRS. * configure.ac: Use gl_EARLY, gl_INIT, and AM_INIT_AUTOMAKE. Simplify AC_CONFIG_AUX_DIR. Generate gnulib/Makefile. * gnulib: New directory, from gnulib-tool. * configure, aclocal.m4: Regenerated. It indeed removed AC_ARG_PROGRAM. It also does this though: -AC_CONFIG_AUX_DIR(`cd $srcdir;pwd`/..) +AC_CONFIG_AUX_DIR(..) I wonder if we need to restore that bit as well. -- Pedro Alves