From: Jeff Kenton <jkenton@tilera.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdb)
Date: Mon, 23 Apr 2012 15:05:00 -0000 [thread overview]
Message-ID: <4F956C45.3060005@tilera.com> (raw)
In-Reply-To: <4F917C1F.3060804@codesourcery.com>
On 04/20/2012 11:09 AM, Yao Qi wrote:
> I don't know tile-gx processor at all, but some comments on code style.
>> diff -r -u -N ./gdb-7.4.50.20120410/gdb/tilegx-linux-nat.c
>> ./gdb/tilegx-linux-nat.c
>> --- ./gdb-7.4.50.20120410/gdb/tilegx-linux-nat.c 1969-12-31
>> 19:00:00.000000000 -0500
>> +++ ./gdb/tilegx-linux-nat.c 2012-04-19 13:55:56.376489000 -0400
>> @@ -0,0 +1,188 @@
>> +
>> +void
>> +supply_gregset (struct regcache* regcache,
>> + const elf_gregset_t *gregsetp)
> Can be `static'? Function name "tilegx_supply_gregset" is better.
>
>
Yao,
I modeled this, and the other "regset" routines, on existing code (e.g.,
sparc64-, hppa-, alpha-, s390-, ppc-) that all implement
supply_gregset() and expose that name for use by processor independent
code. See procfs.c: procfs_fetch_registers() and core-regset.c:
fetch_core_registers() for uses. supply_gregset is declared in gregset.h.
Unless there is now a better way to do it I will leave this as it is.
Thank you.
--jeff
next prev parent reply other threads:[~2012-04-23 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 20:18 Jeff Kenton
2012-04-20 15:18 ` Yao Qi
2012-04-20 15:30 ` Jeff Kenton
2012-04-30 18:44 ` Pedro Alves
2012-04-30 19:06 ` Jeff Kenton
2012-04-30 19:17 ` Pedro Alves
2012-05-07 14:37 ` Jeff Kenton
2012-05-07 15:34 ` Yao Qi
2012-04-23 15:05 ` Jeff Kenton [this message]
2012-04-24 21:25 ` Joel Brobecker
2012-04-24 21:41 ` Joel Brobecker
2012-04-25 1:38 ` Yao Qi
2012-04-20 19:05 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F956C45.3060005@tilera.com \
--to=jkenton@tilera.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox