From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26584 invoked by alias); 23 Apr 2012 14:51:02 -0000 Received: (qmail 26546 invoked by uid 22791); 23 Apr 2012 14:51:00 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from usmamail.tilera.com (HELO USMAMAIL.TILERA.COM) (206.83.70.75) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Apr 2012 14:50:47 +0000 Received: from [10.7.0.51] (10.9.0.23) by USMAExch2.tad.internal.tilera.com (10.3.0.33) with Microsoft SMTP Server id 14.0.694.0; Mon, 23 Apr 2012 10:50:45 -0400 Message-ID: <4F956C45.3060005@tilera.com> Date: Mon, 23 Apr 2012 15:05:00 -0000 From: Jeff Kenton User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:6.0.2) Gecko/20110902 Thunderbird/6.0.2 MIME-Version: 1.0 To: Yao Qi CC: Subject: Re: [PATCH] Add support for Tilera TILE-Gx processor (part 2/2: gdb) References: <4F9066C5.30501@tilera.com> <4F917C1F.3060804@codesourcery.com> In-Reply-To: <4F917C1F.3060804@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00747.txt.bz2 On 04/20/2012 11:09 AM, Yao Qi wrote: > I don't know tile-gx processor at all, but some comments on code style. >> diff -r -u -N ./gdb-7.4.50.20120410/gdb/tilegx-linux-nat.c >> ./gdb/tilegx-linux-nat.c >> --- ./gdb-7.4.50.20120410/gdb/tilegx-linux-nat.c 1969-12-31 >> 19:00:00.000000000 -0500 >> +++ ./gdb/tilegx-linux-nat.c 2012-04-19 13:55:56.376489000 -0400 >> @@ -0,0 +1,188 @@ >> + >> +void >> +supply_gregset (struct regcache* regcache, >> + const elf_gregset_t *gregsetp) > Can be `static'? Function name "tilegx_supply_gregset" is better. > > Yao, I modeled this, and the other "regset" routines, on existing code (e.g., sparc64-, hppa-, alpha-, s390-, ppc-) that all implement supply_gregset() and expose that name for use by processor independent code. See procfs.c: procfs_fetch_registers() and core-regset.c: fetch_core_registers() for uses. supply_gregset is declared in gregset.h. Unless there is now a better way to do it I will leave this as it is. Thank you. --jeff