From: xgsa <xgsa@yandex.ru>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: Doug Evans <dje@google.com>, Eli Zaretskii <eliz@gnu.org>,
Tom Tromey <tromey@redhat.com>
Subject: Re: set print object on should affect MI varobjs (PR mi/13393)
Date: Fri, 13 Apr 2012 08:07:00 -0000 [thread overview]
Message-ID: <4F87DA24.1060806@yandex.ru> (raw)
In-Reply-To: <4F7F2461.8040204@yandex.ru>
Ping, guys! A few people reviewed this patch and said that it is ok in
general, but there are a few minor comments. I have fixed them. Could
somebody finally accept it?
Thanks,
Anton
-------- Original message --------
> I have run all the gdb test suites on my patch. There are no changes
> (except of my new group adding). Testing was done on Linux32. So is it
> ready for check in?
>
>
> Thanks,
> Anton
>
> -------- Original message --------
>> Hi,
>>> Hi. ChangeLog nit:
>>> ...
>> Thanks, the similar case with update_dynamic_varobj_children is fixed
>> too.
>>
>> The same patch and updated changelog are attached.
>>
>>
>> P.S. It seems the question with regression testing is left
>> unanswered. Could someone clarify how it should be done or point me
>> where I could read about it?
>>
>>
>> The original patch description:
>>
>> That patch makes "set print object" option affect MI interface. Here
>> is an example:
>>
>> struct Base {
>> Base() : a(1) {}
>> virtual ~Base() {} // Enforce type to have RTTI
>> int a;
>> };
>>
>> struct Derived : public Base {
>> Derived() : b(2) {}
>> int b;
>> };
>>
>> int main() {
>> Derived b;
>> Base* aPtr = &b;
>> return 0; // [1]
>> }
>>
>> Start gdb in MI mode and run to line [1]. Make -var-create for aPtr.
>> If "set print object" is "on" you will see the type Derived* for the
>> created varobj.
>>
>> See also more details here:
>> http://sourceware.org/bugzilla/show_bug.cgi?id=13393
>>
>>
>> Thanks,
>> Anton.
>
>
>
>
next prev parent reply other threads:[~2012-04-13 7:44 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 19:50 set print object on should affect MI varobjs (PR 13393) xgsa
2011-12-08 8:15 ` xgsa
2011-12-19 20:34 ` xgsa
2011-12-20 17:47 ` Tom Tromey
2011-12-21 19:01 ` set print object on should affect MI varobjs (PR gdb/13393) xgsa
2011-12-21 19:37 ` Jan Kratochvil
2011-12-22 10:17 ` set print object on should affect MI varobjs (PR mi/13393) xgsa
2011-12-24 1:55 ` Jan Kratochvil
2011-12-24 13:56 ` xgsa
2012-01-02 2:22 ` Jan Kratochvil
2012-01-06 15:47 ` RTTI type improvement for (was: "Re: set print object on should affect MI varobjs (PR mi/13393)") xgsa
2012-01-09 14:41 ` Jan Kratochvil
2012-01-11 21:58 ` RTTI type improvement for Tom Tromey
2012-01-12 11:25 ` xgsa
2012-02-06 21:45 ` Tom Tromey
2012-02-08 18:34 ` xgsa
2012-02-10 20:13 ` Tom Tromey
2012-02-19 18:46 ` set print object on should affect MI varobjs (PR mi/13393) xgsa
2012-02-23 4:58 ` xgsa
2012-03-18 16:28 ` xgsa
2012-03-18 20:41 ` Eli Zaretskii
2012-03-19 7:10 ` xgsa
2012-03-19 17:41 ` Eli Zaretskii
2012-03-23 17:09 ` xgsa
2012-03-26 19:08 ` xgsa
2012-03-30 17:51 ` Tom Tromey
2012-03-30 18:01 ` Eli Zaretskii
2012-03-30 20:11 ` xgsa
2012-03-30 18:01 ` Eli Zaretskii
2012-03-30 20:25 ` xgsa
2012-03-30 20:52 ` Eli Zaretskii
2012-03-30 21:26 ` xgsa
2012-03-31 5:54 ` Eli Zaretskii
2012-03-31 6:57 ` xgsa
2012-03-31 9:33 ` xgsa
2012-04-03 0:54 ` Doug Evans
2012-04-03 13:27 ` xgsa
2012-04-06 17:11 ` xgsa
2012-04-13 8:07 ` xgsa [this message]
2012-04-13 12:22 ` Eli Zaretskii
2012-04-13 12:34 ` xgsa
2012-04-13 17:23 ` Tom Tromey
2012-04-14 23:35 ` xgsa
2012-04-16 18:35 ` Jan Kratochvil
2012-07-23 17:21 ` Ulrich Weigand
2012-08-06 7:26 ` xgsa
2012-02-21 14:15 ` RTTI type improvement for xgsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F87DA24.1060806@yandex.ru \
--to=xgsa@yandex.ru \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox