From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30362 invoked by alias); 13 Apr 2012 07:44:11 -0000 Received: (qmail 30352 invoked by uid 22791); 13 Apr 2012 07:44:09 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB X-Spam-Check-By: sourceware.org Received: from forward18.mail.yandex.net (HELO forward18.mail.yandex.net) (95.108.253.143) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Apr 2012 07:43:53 +0000 Received: from smtp17.mail.yandex.net (smtp17.mail.yandex.net [95.108.252.17]) by forward18.mail.yandex.net (Yandex) with ESMTP id 13CE417812BA; Fri, 13 Apr 2012 11:43:51 +0400 (MSK) Received: from smtp17.mail.yandex.net (localhost [127.0.0.1]) by smtp17.mail.yandex.net (Yandex) with ESMTP id CB9EE19000F0; Fri, 13 Apr 2012 11:43:50 +0400 (MSK) Received: from kts.bestnet.kharkov.ua (kts.bestnet.kharkov.ua [80.92.226.138]) by smtp17.mail.yandex.net (nwsmtp/Yandex) with ESMTP id hn5CkQEb-ho5OdIKp; Fri, 13 Apr 2012 11:43:50 +0400 Message-ID: <4F87DA24.1060806@yandex.ru> Date: Fri, 13 Apr 2012 08:07:00 -0000 From: xgsa User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.27) Gecko/20120216 Thunderbird/3.1.19 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" CC: Doug Evans , Eli Zaretskii , Tom Tromey Subject: Re: set print object on should affect MI varobjs (PR mi/13393) References: <4ED92C05.9080803@yandex.ru> <4EF22A4D.80703@yandex.ru> <20111221193630.GA28985@host2.jankratochvil.net> <4EF30389.5010008@yandex.ru> <20111223200951.GA19581@host2.jankratochvil.net> <4EF5D1C5.5010902@yandex.ru> <20120102022153.GA686@host2.jankratochvil.net> <4F07177C.5080201@yandex.ru> <4F32C009.2050103@yandex.ru> <87pqdma1mo.fsf@fleche.redhat.com> <4F412637.2010405@yandex.ru> <4F660CF6.9070008@yandex.ru> <8339953anu.fsf@gnu.org> <4F66DBD0.4000903@yandex.ru> <83vcm01obe.fsf@gnu.org> <4F6CADEF.4080700@yandex.ru> <83vclmynmz.fsf@gnu.org> <4F761708.8080105@yandex.ru> <83r4w9zua0.fsf@gnu.org> <45311333142751@web61.yandex.ru> <83obrdz579.fsf@gnu.org> <87971333177060@web108.yandex.ru> <4F76CF8B.9060303@yandex.ru> <4F7AFB12.4000105@yandex.ru> <4F7F2461.8040204@yandex.ru> In-Reply-To: <4F7F2461.8040204@yandex.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00339.txt.bz2 Ping, guys! A few people reviewed this patch and said that it is ok in general, but there are a few minor comments. I have fixed them. Could somebody finally accept it? Thanks, Anton -------- Original message -------- > I have run all the gdb test suites on my patch. There are no changes > (except of my new group adding). Testing was done on Linux32. So is it > ready for check in? > > > Thanks, > Anton > > -------- Original message -------- >> Hi, >>> Hi. ChangeLog nit: >>> ... >> Thanks, the similar case with update_dynamic_varobj_children is fixed >> too. >> >> The same patch and updated changelog are attached. >> >> >> P.S. It seems the question with regression testing is left >> unanswered. Could someone clarify how it should be done or point me >> where I could read about it? >> >> >> The original patch description: >> >> That patch makes "set print object" option affect MI interface. Here >> is an example: >> >> struct Base { >> Base() : a(1) {} >> virtual ~Base() {} // Enforce type to have RTTI >> int a; >> }; >> >> struct Derived : public Base { >> Derived() : b(2) {} >> int b; >> }; >> >> int main() { >> Derived b; >> Base* aPtr = &b; >> return 0; // [1] >> } >> >> Start gdb in MI mode and run to line [1]. Make -var-create for aPtr. >> If "set print object" is "on" you will see the type Derived* for the >> created varobj. >> >> See also more details here: >> http://sourceware.org/bugzilla/show_bug.cgi?id=13393 >> >> >> Thanks, >> Anton. > > > >