From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [patch] More suggestive displaced-stepping memory error message
Date: Wed, 11 Apr 2012 09:07:00 -0000 [thread overview]
Message-ID: <4F854675.3010301@codesourcery.com> (raw)
In-Reply-To: <20120411084104.GA21919@host2.jankratochvil.net>
On 04/11/2012 04:41 PM, Jan Kratochvil wrote:
>> > So far,
>> > displaced_step_prepare returns 1 for success and 0 for queued request.
>> > We can add one more return value -1 for `unable to do displaced
>> > stepping', so that caller can go non-displaced-stepping path.
> We could discuss first more the cases when it can happen and it is not some
> GDB bug. So far I know only about the ld.so initialization.
>
> As I see there are concerns about the message I will just check in this part,
> it should be sufficient for troubleshooting.
Looks like it is a corner case, and throwing an error message is fine to me.
--
Yao (é½å°§)
next prev parent reply other threads:[~2012-04-11 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 19:55 Jan Kratochvil
2012-04-10 23:48 ` Yao Qi
2012-04-11 8:45 ` Jan Kratochvil
2012-04-11 9:07 ` Yao Qi [this message]
2012-04-11 15:54 ` Pedro Alves
2012-04-11 18:11 ` [commit] " Jan Kratochvil
2012-04-11 16:45 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F854675.3010301@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox