From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28949 invoked by alias); 11 Apr 2012 08:53:28 -0000 Received: (qmail 28939 invoked by uid 22791); 11 Apr 2012 08:53:27 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Apr 2012 08:53:14 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SHtIg-0007Kw-AK from Yao_Qi@mentor.com ; Wed, 11 Apr 2012 01:53:14 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 11 Apr 2012 01:52:58 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Wed, 11 Apr 2012 01:53:13 -0700 Message-ID: <4F854675.3010301@codesourcery.com> Date: Wed, 11 Apr 2012 09:07:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Jan Kratochvil CC: Subject: Re: [patch] More suggestive displaced-stepping memory error message References: <20120410191955.GB31331@host2.jankratochvil.net> <4F84C2D7.1070203@codesourcery.com> <20120411084104.GA21919@host2.jankratochvil.net> In-Reply-To: <20120411084104.GA21919@host2.jankratochvil.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00234.txt.bz2 On 04/11/2012 04:41 PM, Jan Kratochvil wrote: >> > So far, >> > displaced_step_prepare returns 1 for success and 0 for queued request. >> > We can add one more return value -1 for `unable to do displaced >> > stepping', so that caller can go non-displaced-stepping path. > We could discuss first more the cases when it can happen and it is not some > GDB bug. So far I know only about the ld.so initialization. > > As I see there are concerns about the message I will just check in this part, > it should be sufficient for troubleshooting. Looks like it is a corner case, and throwing an error message is fine to me. -- Yao (齐尧)