From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [obv] testsuite: disp-step-syscall.exp: Setup KFAIL for PR server/13796
Date: Sat, 03 Mar 2012 14:30:00 -0000 [thread overview]
Message-ID: <4F522B04.7000607@codesourcery.com> (raw)
In-Reply-To: <20120303070105.GA13581@host2.jankratochvil.net>
On 03/03/2012 03:01 PM, Jan Kratochvil wrote:
> - gdb_test "stepi" ".*" "single step over $syscall"
> + if {$syscall == "vfork" && [is_remote target]} {
> + setup_kfail server/13796 "*-*-*"
> + }
> + set test "single step over $syscall"
> + gdb_test_multiple "stepi" $test {
> + -re "Program terminated with signal SIGILL,.*\r\n$gdb_prompt $" {
> + fail $test
> + return
> + }
> + -re "\r\n$gdb_prompt $" {
> + pass $test
> + }
> + }
> +
Yes, it looks like a bug in GDBserver. The test case doesn't catch
the output below in my env, and get a KPASS.
(gdb) PASS: gdb.base/disp-step-syscall.exp: vfork: set displaced-stepping on
stepi
[Inferior 1 (process 46507) exited normally]^M
Child exited with status 0
GDBserver exiting^M
(gdb) KPASS: gdb.base/disp-step-syscall.exp: vfork: single step over vfork (PRMS server/13796)
Patch below is to fix this, OK to apply?
--
Yao (é½å°§)
gdb/testsuite/
* gdb.base/disp-step-syscall.exp (disp_step_cross_syscall): Catch error
messages for KFAIL.
diff --git a/gdb/testsuite/gdb.base/disp-step-syscall.exp b/gdb/testsuite/gdb.base/disp-step-syscall.exp
index 486701c..915cb97 100644
--- a/gdb/testsuite/gdb.base/disp-step-syscall.exp
+++ b/gdb/testsuite/gdb.base/disp-step-syscall.exp
@@ -127,6 +127,10 @@ proc disp_step_cross_syscall { syscall } { with_test_prefix "$syscall" {
fail $test
return
}
+ -re "\\\[Inferior .* exited normally\\\].*\r\n$gdb_prompt $" {
+ fail $test
+ return
+ }
-re "\r\n$gdb_prompt $" {
pass $test
}
next prev parent reply other threads:[~2012-03-03 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 7:01 Jan Kratochvil
2012-03-03 14:30 ` Yao Qi [this message]
2012-03-03 14:34 ` Jan Kratochvil
2012-03-03 15:17 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F522B04.7000607@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox