From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88491-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3880 invoked by alias); 3 Mar 2012 14:30:49 -0000
Received: (qmail 3863 invoked by uid 22791); 3 Mar 2012 14:30:47 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 Mar 2012 14:30:34 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1S3pyj-0007MX-HL from Yao_Qi@mentor.com ; Sat, 03 Mar 2012 06:30:33 -0800
Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Sat, 3 Mar 2012 06:29:50 -0800
Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Sat, 3 Mar 2012 06:30:32 -0800
Message-ID: <4F522B04.7000607@codesourcery.com>
Date: Sat, 03 Mar 2012 14:30:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
MIME-Version: 1.0
To: Jan Kratochvil <jan.kratochvil@redhat.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [obv] testsuite: disp-step-syscall.exp: Setup KFAIL for PR server/13796
References: <20120303070105.GA13581@host2.jankratochvil.net>
In-Reply-To: <20120303070105.GA13581@host2.jankratochvil.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00113.txt.bz2

On 03/03/2012 03:01 PM, Jan Kratochvil wrote:
> -    gdb_test "stepi" ".*" "single step over $syscall"
> +    if {$syscall == "vfork" && [is_remote target]} {
> +	setup_kfail server/13796 "*-*-*"
> +    }
> +    set test "single step over $syscall"
> +    gdb_test_multiple "stepi" $test {
> +	-re "Program terminated with signal SIGILL,.*\r\n$gdb_prompt $" {
> +	    fail $test
> +	    return
> +	}
> +	-re "\r\n$gdb_prompt $" {
> +	    pass $test
> +	}
> +    }
> +

Yes, it looks like a bug in GDBserver.  The test case doesn't catch
the output below in my env, and get a KPASS.

(gdb) PASS: gdb.base/disp-step-syscall.exp: vfork: set displaced-stepping on
stepi
[Inferior 1 (process 46507) exited normally]^M

Child exited with status 0
GDBserver exiting^M
(gdb) KPASS: gdb.base/disp-step-syscall.exp: vfork: single step over vfork (PRMS server/13796)

Patch below is to fix this, OK to apply?

-- 
Yao (齐尧) 

gdb/testsuite/
	* gdb.base/disp-step-syscall.exp (disp_step_cross_syscall): Catch error
	messages for KFAIL.

diff --git a/gdb/testsuite/gdb.base/disp-step-syscall.exp b/gdb/testsuite/gdb.base/disp-step-syscall.exp
index 486701c..915cb97 100644
--- a/gdb/testsuite/gdb.base/disp-step-syscall.exp
+++ b/gdb/testsuite/gdb.base/disp-step-syscall.exp
@@ -127,6 +127,10 @@ proc disp_step_cross_syscall { syscall } { with_test_prefix "$syscall" {
            fail $test
            return
        }
+       -re "\\\[Inferior .* exited normally\\\].*\r\n$gdb_prompt $" {
+           fail $test
+           return
+       }
        -re "\r\n$gdb_prompt $" {
            pass $test
        }