Re: RFA: New port: ia64-hp-openvms (3/3) - ia64-vms-tdep.c

[Pedro Alves <palves@redhat.com>]

On 02/21/2012 04:07 PM, Tristan Gingold wrote:
> 
> On Feb 15, 2012, at 1:17 PM, Pedro Alves wrote:

>> Ah, missed that.  Fine with me to stay with malloc.  What does
>> libunwind do when one returns -UNW_ENOMEM?
> 
> My understanding is that libunwind properly propagate the error, and Â…
> 
>>  Does GDB end up recovering correctly,
>> or do we end up busted anyway?
> 
> Â… gdb recovers.

I was hoping you'd quickly just hack an unconditional "return -UNW_ENOMEM;"
to find it out, but ...

> But because it is so likely that gdb will fail later, I have switched to xmalloc/xfree.

... then it doesn't matter.

Okay.  Just some minor nits below.

> diff --git a/configure.ac b/configure.ac
> index 9d48e90..c24fff4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -929,8 +929,8 @@ case "${target}" in
>      noconfigdirs="$noconfigdirs libgui itcl ld"
>      ;;
>    ia64*-*-*vms*)
> -    # No gdb or ld support yet.
> -    noconfigdirs="$noconfigdirs readline libgui itcl gdb ld"
> +    # No ld support yet.
> +    noconfigdirs="$noconfigdirs libgui itcl ld"
>      ;;
>    i[[3456789]]86-w64-mingw*)
>      ;;

Remember this should be synced with gcc. (and needs a ChangeLog entry).

> +ia64-*-*vms*)
> +	# Target: Intel IA-64 running OpenVMS
> +	gdb_target_obs="ia64-tdep.o ia64-vms-tdep.o"
> +	;;

This deserves a NEWS entry (New targets).  (No need to wait for that
to commit this).

> +#include "defs.h"
> +#include "frame-unwind.h"
> +#include "ia64-tdep.h"
> +#include "osabi.h"
> +#include "gdbtypes.h"
> +#include "solib.h"

Interesting dependency.  If not needed, please remove (and all other
unnecessary includes).

> +#include "target.h"
> +#include "frame.h"
> +#include "regcache.h"
> +#include "gdbcore.h"
> +#include "inferior.h"

> +/* Libunwind callback accessor function for cleanup.  */
> +static void

Empty line between comment and function, please.  Here and elsewhere.

> +ia64_vms_put_unwind_info (unw_addr_space_t as,

-- 
Pedro Alves