From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31114 invoked by alias); 22 Feb 2012 19:33:03 -0000 Received: (qmail 31098 invoked by uid 22791); 22 Feb 2012 19:33:01 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,KAM_MX3,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_NV,T_RP_MATCHES_RCVD,URIBL_BLACK X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Feb 2012 19:32:48 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1MJWPIR029159 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 22 Feb 2012 14:32:25 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q1MJWOwi002122; Wed, 22 Feb 2012 14:32:24 -0500 Message-ID: <4F4542C7.4070504@redhat.com> Date: Wed, 22 Feb 2012 19:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Tristan Gingold CC: "gdb-patches@sourceware.org ml" , Rupp Douglas Subject: Re: RFA: New port: ia64-hp-openvms (3/3) - ia64-vms-tdep.c References: <6AD2487F-8409-4F4E-93A6-9DB7FD195E71@adacore.com> <190A7167-B038-4EC0-82FD-815B306B4975@adacore.com> <4D8B23BF-A8D1-4698-8539-DF953219948B@adacore.com> <4F3A9ED3.7090408@redhat.com> <3F9413FC-FB03-4970-B9FB-C628E5663826@adacore.com> <4F3BA24E.8070009@redhat.com> <5ED28A1C-018A-4060-9D16-CABBB23EB860@adacore.com> In-Reply-To: <5ED28A1C-018A-4060-9D16-CABBB23EB860@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00484.txt.bz2 On 02/21/2012 04:07 PM, Tristan Gingold wrote: > > On Feb 15, 2012, at 1:17 PM, Pedro Alves wrote: >> Ah, missed that. Fine with me to stay with malloc. What does >> libunwind do when one returns -UNW_ENOMEM? > > My understanding is that libunwind properly propagate the error, and … > >> Does GDB end up recovering correctly, >> or do we end up busted anyway? > > … gdb recovers. I was hoping you'd quickly just hack an unconditional "return -UNW_ENOMEM;" to find it out, but ... > But because it is so likely that gdb will fail later, I have switched to xmalloc/xfree. ... then it doesn't matter. Okay. Just some minor nits below. > diff --git a/configure.ac b/configure.ac > index 9d48e90..c24fff4 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -929,8 +929,8 @@ case "${target}" in > noconfigdirs="$noconfigdirs libgui itcl ld" > ;; > ia64*-*-*vms*) > - # No gdb or ld support yet. > - noconfigdirs="$noconfigdirs readline libgui itcl gdb ld" > + # No ld support yet. > + noconfigdirs="$noconfigdirs libgui itcl ld" > ;; > i[[3456789]]86-w64-mingw*) > ;; Remember this should be synced with gcc. (and needs a ChangeLog entry). > +ia64-*-*vms*) > + # Target: Intel IA-64 running OpenVMS > + gdb_target_obs="ia64-tdep.o ia64-vms-tdep.o" > + ;; This deserves a NEWS entry (New targets). (No need to wait for that to commit this). > +#include "defs.h" > +#include "frame-unwind.h" > +#include "ia64-tdep.h" > +#include "osabi.h" > +#include "gdbtypes.h" > +#include "solib.h" Interesting dependency. If not needed, please remove (and all other unnecessary includes). > +#include "target.h" > +#include "frame.h" > +#include "regcache.h" > +#include "gdbcore.h" > +#include "inferior.h" > +/* Libunwind callback accessor function for cleanup. */ > +static void Empty line between comment and function, please. Here and elsewhere. > +ia64_vms_put_unwind_info (unw_addr_space_t as, -- Pedro Alves