From: Phil Muldoon <pmuldoon@redhat.com>
To: Scott Goldman <scottjg@vmware.com>
Cc: "eliz@gnu.org" <eliz@gnu.org>, "dje@google.com" <dje@google.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Allow user-defined as a category for python gdb macros (resend)
Date: Thu, 16 Feb 2012 14:23:00 -0000 [thread overview]
Message-ID: <4F3CFA30.7090408@redhat.com> (raw)
In-Reply-To: <03E840D17E263A48A5766AD576E0423A03D72B6547@exch-mbx-111.vmware.com>
On 02/15/2012 09:14 AM, Scott Goldman wrote:
> Hi Phil, Eli, Doug.
>
> Thanks for the feedback. I adjusted the changelog, added a test case, and updated the documentation as per your suggestions.
>
>> [Doug]
>> The documentation needs to make clear that "user" means "those
>> commands defined in class_user" and not any command defined by the
>> user.
> I think I understand what you're saying. I suppose the distinction is that `help user-defined` may now show python commands in addition to what are traditionally known as user-defined commands. I updated the documentation to reflect this. I no longer use the phrase "user-defined python commands", instead I refer to commands as "user-defined commands" or "python commands". I also clarified that `help user-defined` may also show python commands that were declared under COMMAND_USER. Hopefully that's what you had in mind. Any further suggestions on how you'd like the doc reworked are welcome.
>
> -sjg
Thanks for taking care of the issues I raised. I have no further comments. Please wait for Doug to give code check-in approval (or more comments), and similarly with Eli with documentation.
Cheers
Phil
next prev parent reply other threads:[~2012-02-16 12:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 0:49 Scott Goldman
2012-02-14 3:12 ` Doug Evans
2012-02-14 7:57 ` Scott Goldman
2012-02-14 18:09 ` Eli Zaretskii
2012-02-14 20:19 ` Doug Evans
2012-02-14 12:48 ` Phil Muldoon
2012-02-15 9:27 ` Scott Goldman
2012-02-16 14:23 ` Phil Muldoon [this message]
2012-02-16 17:16 ` Eli Zaretskii
2012-02-23 3:03 ` Doug Evans
2012-02-23 3:32 ` Scott Goldman
2012-02-23 4:24 ` Eli Zaretskii
2012-02-23 5:13 ` Scott Goldman
2012-02-23 6:03 ` Doug Evans
2012-02-23 6:56 ` Scott Goldman
2012-02-23 8:21 ` Scott Goldman
2012-02-24 23:49 ` Scott Goldman
2012-02-28 1:36 ` Doug Evans
2012-02-28 4:18 ` Scott Goldman
2012-02-28 7:51 ` Doug Evans
2012-02-29 0:45 ` [doc RFA] " Doug Evans
2012-02-29 4:17 ` Eli Zaretskii
2012-03-01 19:31 ` Doug Evans
2012-03-01 20:26 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3CFA30.7090408@redhat.com \
--to=pmuldoon@redhat.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=scottjg@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox