From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21470 invoked by alias); 16 Feb 2012 12:45:00 -0000 Received: (qmail 21394 invoked by uid 22791); 16 Feb 2012 12:44:59 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_SJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Feb 2012 12:44:38 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1GCiYNI015383 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 Feb 2012 07:44:34 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1GCiWBb023356; Thu, 16 Feb 2012 07:44:33 -0500 Message-ID: <4F3CFA30.7090408@redhat.com> Date: Thu, 16 Feb 2012 14:23:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Scott Goldman CC: "eliz@gnu.org" , "dje@google.com" , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Allow user-defined as a category for python gdb macros (resend) References: <03E840D17E263A48A5766AD576E0423A03D72B653F@exch-mbx-111.vmware.com>,<4F3A5820.3080905@redhat.com> <03E840D17E263A48A5766AD576E0423A03D72B6547@exch-mbx-111.vmware.com> In-Reply-To: <03E840D17E263A48A5766AD576E0423A03D72B6547@exch-mbx-111.vmware.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00324.txt.bz2 On 02/15/2012 09:14 AM, Scott Goldman wrote: > Hi Phil, Eli, Doug. > > Thanks for the feedback. I adjusted the changelog, added a test case, and updated the documentation as per your suggestions. > >> [Doug] >> The documentation needs to make clear that "user" means "those >> commands defined in class_user" and not any command defined by the >> user. > I think I understand what you're saying. I suppose the distinction is that `help user-defined` may now show python commands in addition to what are traditionally known as user-defined commands. I updated the documentation to reflect this. I no longer use the phrase "user-defined python commands", instead I refer to commands as "user-defined commands" or "python commands". I also clarified that `help user-defined` may also show python commands that were declared under COMMAND_USER. Hopefully that's what you had in mind. Any further suggestions on how you'd like the doc reworked are welcome. > > -sjg Thanks for taking care of the issues I raised. I have no further comments. Please wait for Doug to give code check-in approval (or more comments), and similarly with Eli with documentation. Cheers Phil