From: Pedro Alves <palves@redhat.com>
To: "Gustavo, Luis" <luis_gustavo@mentor.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [rfc target-side break conditions 3/5 v2] GDB-side changes
Date: Thu, 09 Feb 2012 13:00:00 -0000 [thread overview]
Message-ID: <4F33C34D.8040500@redhat.com> (raw)
In-Reply-To: <4F3107C2.2060400@mentor.com>
BTW,
On 02/07/2012 11:15 AM, Luis Gustavo wrote:
> +/* Returns true if BPT is a breakpoint of any kind. */
This is ambiguous, because "breakpoint" can mean all kinds of breakpoints,
watchpoints, tracepoints, whateverpoints.
Witness:
/* This is for all kinds of breakpoints. */
struct breakpoint
{
Best be a bit more explicit.
> +
> +extern int is_breakpoint (const struct breakpoint *bpt);
--
Pedro Alves
next prev parent reply other threads:[~2012-02-09 13:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 20:34 Luis Gustavo
2012-02-06 20:27 ` Tom Tromey
2012-02-07 11:16 ` Luis Gustavo
2012-02-08 19:33 ` Pedro Alves
2012-02-08 20:56 ` Luis Gustavo
2012-02-09 12:56 ` Pedro Alves
2012-02-22 15:29 ` Luis Gustavo
2012-02-23 17:38 ` Pedro Alves
2012-02-24 12:20 ` Luis Gustavo
2012-02-24 13:01 ` Pedro Alves
2012-02-24 13:04 ` Luis Gustavo
2012-02-09 13:00 ` Pedro Alves [this message]
2012-02-07 19:13 ` Pedro Alves
2012-02-07 19:26 ` Stan Shebs
2012-02-07 22:08 ` Stan Shebs
2012-02-08 23:13 ` Luis Gustavo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33C34D.8040500@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis_gustavo@mentor.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox