From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87768-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7051 invoked by alias); 9 Feb 2012 13:00:16 -0000
Received: (qmail 7037 invoked by uid 22791); 9 Feb 2012 13:00:14 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Feb 2012 13:00:02 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q19Cxx6Q020695	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 9 Feb 2012 07:59:59 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q19CxvdV030828;	Thu, 9 Feb 2012 07:59:58 -0500
Message-ID: <4F33C34D.8040500@redhat.com>
Date: Thu, 09 Feb 2012 13:00:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0
MIME-Version: 1.0
To: "Gustavo, Luis" <luis_gustavo@mentor.com>
CC: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [rfc target-side break conditions 3/5 v2]  GDB-side changes
References: <4F230A13.9060400@mentor.com> <m3vcnjn1xa.fsf@fleche.redhat.com> <4F3107C2.2060400@mentor.com>
In-Reply-To: <4F3107C2.2060400@mentor.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-02/txt/msg00140.txt.bz2

BTW,

On 02/07/2012 11:15 AM, Luis Gustavo wrote:
> +/* Returns true if BPT is a breakpoint of any kind.  */

This is ambiguous, because "breakpoint" can mean all kinds of breakpoints,
watchpoints, tracepoints, whateverpoints.

Witness:

 /* This is for all kinds of breakpoints.  */

 struct breakpoint
 {

Best be a bit more explicit.

> +
> +extern int is_breakpoint (const struct breakpoint *bpt);

-- 
Pedro Alves