Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Do not open Python scripts twice #2  [Re: [RFC] Crash sourcing Python script on Windows]
Date: Mon, 23 Jan 2012 19:57:00 -0000	[thread overview]
Message-ID: <4F1DA99C.8030607@redhat.com> (raw)
In-Reply-To: <20120123181125.GA26683@host2.jankratochvil.net>

Does anyone know if there's a way to create a PyFile from an open Windows
file HANDLE (that is, an hypothetical PyFile_from_HANDLE function)?

If there is, we could do something like:

 static PyObject *
 PyFile_from_FILE (FILE *file, const char *filename, char *mode)
 {
 #ifdef _WIN32
   HANDLE h = _get_osfhandle (fileno (file));
   return PyFile_from_HANDLE (h, ...);
 #else
   return PyFile_FromFile(file, filename, mode, ...);
 }

Unlike libc objects, HANDLEs are common to all loaded libcs, given
that they live in the common Win32/NT layer beneath libc, so that
would work around the multiple libc's problem, and, would plug the
race on Windows too.

_get_osfhandle:
http://msdn.microsoft.com/en-us/library/ks2530z6.aspx

-- 
Pedro Alves


      parent reply	other threads:[~2012-01-23 18:41 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-28 23:24 [RFC] Crash sourcing Python script on Windows Joel Brobecker
2011-09-29  2:00 ` Paul_Koning
2011-09-29  2:19   ` John Spencer
2011-09-29  4:47     ` Joel Brobecker
2011-09-29  7:30       ` Eli Zaretskii
2011-09-29  8:54         ` Kai Tietz
2011-09-29  9:48           ` Eli Zaretskii
2011-09-29  9:51             ` Kai Tietz
2011-09-29 10:54       ` Pedro Alves
2011-09-29 12:33         ` Eli Zaretskii
2011-09-29 12:48           ` Kai Tietz
2011-09-29 13:19           ` Pedro Alves
2011-09-29  7:26     ` Eli Zaretskii
2011-10-03 20:05     ` Tom Tromey
2011-09-29  7:20   ` Eli Zaretskii
2011-10-03 20:02 ` Tom Tromey
2011-10-03 20:53   ` Joel Brobecker
2011-10-04 17:08     ` Tom Tromey
2012-01-23 18:14 ` [patch] Do not open Python scripts twice #2 [Re: [RFC] Crash sourcing Python script on Windows] Jan Kratochvil
2012-01-23 18:41   ` Pedro Alves
2012-01-23 21:55     ` Jan Kratochvil
2012-01-23 22:08       ` Doug Evans
2012-01-23 22:47         ` Jan Kratochvil
2012-01-23 23:47           ` Doug Evans
2012-01-24 14:45             ` Jan Kratochvil
2012-01-24 18:56               ` Doug Evans
2012-01-24 19:41                 ` Jan Kratochvil
2012-01-24 22:20                   ` Doug Evans
2012-01-24 23:49                     ` Jan Kratochvil
2012-01-25 22:30                       ` Jan Kratochvil
2012-01-26  7:18                         ` Joel Brobecker
2012-01-26 22:03                           ` [commit] " Jan Kratochvil
2012-01-24 15:15             ` Pedro Alves
2012-01-23 19:57   ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1DA99C.8030607@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox