From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <palves@redhat.com>,
gdb-patches@sourceware.org, Doug Evans <dje@google.com>
Subject: Re: [patch] Do not open Python scripts twice #2 [Re: [RFC] Crash sourcing Python script on Windows]
Date: Thu, 26 Jan 2012 07:18:00 -0000 [thread overview]
Message-ID: <20120126062103.GU31383@adacore.com> (raw)
In-Reply-To: <20120125212636.GA23994@host2.jankratochvil.net>
Hi Jan,
> gdb/
> 2012-01-25 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Do not open script filenames twice.
> * cli/cli-cmds.c (source_script_from_stream): Pass to
> source_python_script also STREAM.
> * python/py-auto-load.c (source_section_scripts): Pass to
> source_python_script_for_objfile also STREAM.
> (auto_load_objfile_script): Pass to source_python_script_for_objfile
> also INPUT.
> * python/python-internal.h (source_python_script_for_objfile): New
> parameter file, rename parameter file to filename.
> * python/python.c (python_run_simple_file): Call PyRun_SimpleFile
> instead if !_WIN32. Update the function comment.
> (source_python_script, source_python_script_for_objfile)
> (source_python_script): New parameter file, rename parameter file to
> filename. Pass FILENAME to python_run_simple_file.
> * python/python.h (source_python_script): New parameter file, rename
> parameter file to filename.
The patch looks good to me and I would probably have come up with
the same sort of changes myself. I tested it on x86-windows, and
sourcing Python files still worked perfectly. I also ran it against
AdaCore's testsuite and no regression either.
--
Joel
next prev parent reply other threads:[~2012-01-26 6:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 23:24 [RFC] Crash sourcing Python script on Windows Joel Brobecker
2011-09-29 2:00 ` Paul_Koning
2011-09-29 2:19 ` John Spencer
2011-09-29 4:47 ` Joel Brobecker
2011-09-29 7:30 ` Eli Zaretskii
2011-09-29 8:54 ` Kai Tietz
2011-09-29 9:48 ` Eli Zaretskii
2011-09-29 9:51 ` Kai Tietz
2011-09-29 10:54 ` Pedro Alves
2011-09-29 12:33 ` Eli Zaretskii
2011-09-29 12:48 ` Kai Tietz
2011-09-29 13:19 ` Pedro Alves
2011-09-29 7:26 ` Eli Zaretskii
2011-10-03 20:05 ` Tom Tromey
2011-09-29 7:20 ` Eli Zaretskii
2011-10-03 20:02 ` Tom Tromey
2011-10-03 20:53 ` Joel Brobecker
2011-10-04 17:08 ` Tom Tromey
2012-01-23 18:14 ` [patch] Do not open Python scripts twice #2 [Re: [RFC] Crash sourcing Python script on Windows] Jan Kratochvil
2012-01-23 18:41 ` Pedro Alves
2012-01-23 21:55 ` Jan Kratochvil
2012-01-23 22:08 ` Doug Evans
2012-01-23 22:47 ` Jan Kratochvil
2012-01-23 23:47 ` Doug Evans
2012-01-24 14:45 ` Jan Kratochvil
2012-01-24 18:56 ` Doug Evans
2012-01-24 19:41 ` Jan Kratochvil
2012-01-24 22:20 ` Doug Evans
2012-01-24 23:49 ` Jan Kratochvil
2012-01-25 22:30 ` Jan Kratochvil
2012-01-26 7:18 ` Joel Brobecker [this message]
2012-01-26 22:03 ` [commit] " Jan Kratochvil
2012-01-24 15:15 ` Pedro Alves
2012-01-23 19:57 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120126062103.GU31383@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox