From: Michael Eager <eager@eagerm.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] PowerPC 32 with Secure PLT
Date: Wed, 18 Jan 2012 16:45:00 -0000 [thread overview]
Message-ID: <4F16F527.2000800@eagerm.com> (raw)
In-Reply-To: <4F16E632.6010102@eagerm.com>
On 01/18/2012 07:33 AM, Michael Eager wrote:
> On 01/18/2012 04:08 AM, Joel Brobecker wrote:
>>> + target = (CORE_ADDR) read_memory_unsigned_integer (target, 4, byte_order);
>>
>> This is an area where I am not sure, but I think it would be better
>> to use read_memory_typed_address. I think the address type that you
>> want is: builtin_type (gdbarch)->builtin_func_ptr.
I think I'd rather leave the size explicit, rather than making
it indirect (and unclear). This routine is only for PowerPC 32 and
the size of the value is always four bytes.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2012-01-18 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 4:00 Michael Eager
2012-01-18 12:18 ` Joel Brobecker
2012-01-18 16:37 ` Michael Eager
2012-01-18 16:45 ` Michael Eager [this message]
2012-01-18 17:03 ` Joel Brobecker
2012-01-18 18:23 ` Michael Eager
-- strict thread matches above, loose matches on Subject: below --
2012-01-18 3:36 Michael Eager
2012-01-25 0:37 ` Michael Eager
2012-01-25 1:12 ` Ryan Arnold
2012-01-25 1:55 ` Michael Eager
2012-01-30 17:19 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F16F527.2000800@eagerm.com \
--to=eager@eagerm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox