From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20426 invoked by alias); 18 Jan 2012 16:37:21 -0000 Received: (qmail 20258 invoked by uid 22791); 18 Jan 2012 16:37:20 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a40.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Jan 2012 16:36:57 +0000 Received: from homiemail-a40.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a40.g.dreamhost.com (Postfix) with ESMTP id CF2E274C087; Wed, 18 Jan 2012 08:36:56 -0800 (PST) Received: from redwood.eagercon.com (c-76-102-3-160.hsd1.ca.comcast.net [76.102.3.160]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a40.g.dreamhost.com (Postfix) with ESMTPSA id 9C92374C084; Wed, 18 Jan 2012 08:36:56 -0800 (PST) Message-ID: <4F16F527.2000800@eagerm.com> Date: Wed, 18 Jan 2012 16:45:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] PowerPC 32 with Secure PLT References: <4F163E35.1080505@eagerm.com> <20120118120831.GB31383@adacore.com> <4F16E632.6010102@eagerm.com> In-Reply-To: <4F16E632.6010102@eagerm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00671.txt.bz2 On 01/18/2012 07:33 AM, Michael Eager wrote: > On 01/18/2012 04:08 AM, Joel Brobecker wrote: >>> + target = (CORE_ADDR) read_memory_unsigned_integer (target, 4, byte_order); >> >> This is an area where I am not sure, but I think it would be better >> to use read_memory_typed_address. I think the address type that you >> want is: builtin_type (gdbarch)->builtin_func_ptr. I think I'd rather leave the size explicit, rather than making it indirect (and unclear). This routine is only for PowerPC 32 and the size of the value is always four bytes. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077