From: Pedro Alves <palves@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc v3][4/6] Readlink as file I/O target operation
Date: Tue, 17 Jan 2012 20:09:00 -0000 [thread overview]
Message-ID: <4F15D54E.7040503@redhat.com> (raw)
In-Reply-To: <201201171947.q0HJlcHD024179@d03av02.boulder.ibm.com>
Only minor nits:
On 01/17/2012 07:47 PM, Ulrich Weigand wrote:
> + /* Read value of symbolic link FILENAME on the remote target. Return
> + a null-terminated string allocated via xmalloc, or NULL if an error
> + occurs (and set *REMOTE_ERRNO). */
> + char *(*to_fileio_readlink) (const char *filename, int *remote_errno);
> +
s/the remote target/the target/
s/REMOTE_ERRNO/TARGET_ERRNO/.
s/remote_errno/target_errno/.
I spotted several instances of this in this patch.
--
Pedro Alves
next prev parent reply other threads:[~2012-01-17 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 19:49 Ulrich Weigand
2012-01-17 20:09 ` Pedro Alves [this message]
2012-01-17 20:27 ` Ulrich Weigand
2012-01-19 10:03 Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F15D54E.7040503@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox