From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27205 invoked by alias); 17 Jan 2012 20:09:10 -0000 Received: (qmail 27197 invoked by uid 22791); 17 Jan 2012 20:09:08 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Jan 2012 20:08:50 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0HK8mpf027399 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 17 Jan 2012 15:08:48 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0HK8lra010599; Tue, 17 Jan 2012 15:08:47 -0500 Message-ID: <4F15D54E.7040503@redhat.com> Date: Tue, 17 Jan 2012 20:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Ulrich Weigand CC: gdb-patches@sourceware.org Subject: Re: [rfc v3][4/6] Readlink as file I/O target operation References: <201201171947.q0HJlcHD024179@d03av02.boulder.ibm.com> In-Reply-To: <201201171947.q0HJlcHD024179@d03av02.boulder.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00635.txt.bz2 Only minor nits: On 01/17/2012 07:47 PM, Ulrich Weigand wrote: > + /* Read value of symbolic link FILENAME on the remote target. Return > + a null-terminated string allocated via xmalloc, or NULL if an error > + occurs (and set *REMOTE_ERRNO). */ > + char *(*to_fileio_readlink) (const char *filename, int *remote_errno); > + s/the remote target/the target/ s/REMOTE_ERRNO/TARGET_ERRNO/. s/remote_errno/target_errno/. I spotted several instances of this in this patch. -- Pedro Alves