From: Pedro Alves <palves@redhat.com>
To: "Gustavo, Luis" <luis_gustavo@mentor.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFC stub-side break conditions 3/5] GDB-side changes
Date: Thu, 12 Jan 2012 19:44:00 -0000 [thread overview]
Message-ID: <4F0F34EB.3000206@redhat.com> (raw)
In-Reply-To: <4F07779A.10808@mentor.com>
On 01/06/2012 10:37 PM, Luis Machado wrote:
> On 01/06/2012 06:44 AM, Eli Zaretskii wrote:
>>> + /* Print whether the remote stub is doing the breakpoint's condition
>>> + evaluation. If GDB is doing the evaluation, don't print anything. */
>>> + if (loc&& is_breakpoint (b)&& loc->cond_bytecode
>>> + && breakpoint_condition_evaluation_mode ()
>>> + != condition_evaluation_gdb)
>>> + {
>>> + ui_out_text (uiout, " (");
>>> + ui_out_field_string (uiout, "condeval",
>>> + breakpoint_condition_evaluation_mode ());
>> I suggest "cond.eval." instead of "condeval". Better yet, how about
>> "evaluated by"?
> Sounds good. I'll make that change.
Isn't that only visible by MI? Are spaces valid in MI field names?
next prev parent reply other threads:[~2012-01-12 19:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 14:56 Luis Machado
2012-01-06 8:47 ` Eli Zaretskii
2012-01-06 22:38 ` Luis Machado
2012-01-07 7:54 ` Eli Zaretskii
2012-01-12 19:44 ` Pedro Alves [this message]
2012-01-12 22:20 ` Tom Tromey
2012-01-13 8:08 ` Eli Zaretskii
2012-01-13 14:33 ` Tom Tromey
2012-01-13 14:44 ` Pedro Alves
2012-01-06 16:23 ` Pedro Alves
2012-01-10 11:14 ` Luis Machado
2012-01-12 19:31 ` Pedro Alves
2012-01-06 21:44 ` Tom Tromey
2012-01-10 14:51 ` Luis Machado
2012-01-13 15:36 ` Yao Qi
2012-01-13 18:13 ` Pedro Alves
2012-01-14 0:42 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0F34EB.3000206@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=luis_gustavo@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox