From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-87030-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31078 invoked by alias); 12 Jan 2012 19:31:14 -0000
Received: (qmail 31070 invoked by uid 22791); 12 Jan 2012 19:31:13 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jan 2012 19:30:59 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0CJUrxA029037	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 12 Jan 2012 14:30:53 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q0CJUpvu010065;	Thu, 12 Jan 2012 14:30:52 -0500
Message-ID: <4F0F34EB.3000206@redhat.com>
Date: Thu, 12 Jan 2012 19:44:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0
MIME-Version: 1.0
To: "Gustavo, Luis" <luis_gustavo@mentor.com>
CC: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFC stub-side break conditions 3/5]  GDB-side changes
References: <4F05BA10.3090107@mentor.com> <83y5tlnrsx.fsf@gnu.org> <4F07779A.10808@mentor.com>
In-Reply-To: <4F07779A.10808@mentor.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00427.txt.bz2

On 01/06/2012 10:37 PM, Luis Machado wrote:
> On 01/06/2012 06:44 AM, Eli Zaretskii wrote:

>>> +      /* Print whether the remote stub is doing the breakpoint's condition
>>> +     evaluation.  If GDB is doing the evaluation, don't print anything.  */
>>> +      if (loc&&  is_breakpoint (b)&&  loc->cond_bytecode
>>> +    &&  breakpoint_condition_evaluation_mode ()
>>> +      != condition_evaluation_gdb)
>>> +    {
>>> +      ui_out_text (uiout, " (");
>>> +      ui_out_field_string (uiout, "condeval",
>>> +                   breakpoint_condition_evaluation_mode ());
>> I suggest "cond.eval." instead of "condeval".  Better yet, how about
>> "evaluated by"?
> Sounds good. I'll make that change.

Isn't that only visible by MI?  Are spaces valid in MI field names?