From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [patch 2/2] Fix linking on non-x86* after libgdb.a removal
Date: Tue, 10 Jan 2012 19:32:00 -0000 [thread overview]
Message-ID: <4F0C91FC.9080902@redhat.com> (raw)
In-Reply-To: <20120109210144.GA31823@host2.jankratochvil.net>
On 01/09/2012 09:01 PM, Jan Kratochvil wrote:
> @@ -72,8 +72,7 @@ core_file_command (char *filename, int from_tty)
> {
> dont_repeat (); /* Either way, seems bogus. */
>
> - if (core_target == NULL)
> - error (_("GDB can't read core files on this machine."));
> + gdb_assert (core_target != NULL);
I think we should stop expecting it in the testsuite too. Any objections to this?
gdb/testsuite/
2012-01-10 Pedro Alves <palves@redhat.com>
* gdb.base/default.exp (core-file): Don't expect "GDB can't read
core files on this machine" anymore.
---
gdb/testsuite/gdb.base/default.exp | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp
index 74d2d2d..9677396 100644
--- a/gdb/testsuite/gdb.base/default.exp
+++ b/gdb/testsuite/gdb.base/default.exp
@@ -102,7 +102,7 @@ gdb_test "commands" "Argument required .one or more breakpoint numbers...*" "com
gdb_test "condition" "Argument required .breakpoint number.*" "condition"
#test core-file
-gdb_test "core-file" "No core file now.|GDB can't read core files on this machine." "core-file"
+gdb_test "core-file" "No core file now." "core-file"
#test delete "d" abbreviation
gdb_test_no_output "d" "delete \"d\" abbreviation"
#test delete
next prev parent reply other threads:[~2012-01-10 19:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 20:43 Jan Kratochvil
2012-01-05 14:46 ` Ulrich Weigand
2012-01-05 15:25 ` Jan Kratochvil
2012-01-05 17:10 ` [commit, s390] Move corelow.o to target config (Re: [patch 2/2] Fix linking on non-x86* after libgdb.a removal) Ulrich Weigand
2012-01-05 17:12 ` [patch 2/2] Fix linking on non-x86* after libgdb.a removal Ulrich Weigand
2012-01-09 21:02 ` Jan Kratochvil
2012-01-10 16:06 ` Ulrich Weigand
2012-01-10 17:17 ` [commit] " Jan Kratochvil
2012-01-10 19:32 ` Pedro Alves [this message]
2012-01-10 19:55 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0C91FC.9080902@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox