From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31022 invoked by alias); 10 Jan 2012 19:31:27 -0000 Received: (qmail 30972 invoked by uid 22791); 10 Jan 2012 19:31:25 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jan 2012 19:31:12 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q0AJVAWT027963 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 10 Jan 2012 14:31:10 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q0AJV8pm028087; Tue, 10 Jan 2012 14:31:09 -0500 Message-ID: <4F0C91FC.9080902@redhat.com> Date: Tue, 10 Jan 2012 19:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: [patch 2/2] Fix linking on non-x86* after libgdb.a removal References: <20120105152451.GA4548@host2.jankratochvil.net> <201201051712.q05HCBu8024844@d06av02.portsmouth.uk.ibm.com> <20120109210144.GA31823@host2.jankratochvil.net> In-Reply-To: <20120109210144.GA31823@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00305.txt.bz2 On 01/09/2012 09:01 PM, Jan Kratochvil wrote: > @@ -72,8 +72,7 @@ core_file_command (char *filename, int from_tty) > { > dont_repeat (); /* Either way, seems bogus. */ > > - if (core_target == NULL) > - error (_("GDB can't read core files on this machine.")); > + gdb_assert (core_target != NULL); I think we should stop expecting it in the testsuite too. Any objections to this? gdb/testsuite/ 2012-01-10 Pedro Alves * gdb.base/default.exp (core-file): Don't expect "GDB can't read core files on this machine" anymore. --- gdb/testsuite/gdb.base/default.exp | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp index 74d2d2d..9677396 100644 --- a/gdb/testsuite/gdb.base/default.exp +++ b/gdb/testsuite/gdb.base/default.exp @@ -102,7 +102,7 @@ gdb_test "commands" "Argument required .one or more breakpoint numbers...*" "com gdb_test "condition" "Argument required .breakpoint number.*" "condition" #test core-file -gdb_test "core-file" "No core file now.|GDB can't read core files on this machine." "core-file" +gdb_test "core-file" "No core file now." "core-file" #test delete "d" abbreviation gdb_test_no_output "d" "delete \"d\" abbreviation" #test delete