From: Stan Shebs <stanshebs@earthlink.net>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix build on sparc (remote.c/tracepoints)
Date: Sat, 26 Nov 2011 23:42:00 -0000 [thread overview]
Message-ID: <4ED17954.7070602@earthlink.net> (raw)
In-Reply-To: <20111126205107.GB24943@adacore.com>
On 11/26/11 12:51 PM, Joel Brobecker wrote:
>> gdb/ChangeLog:
>>
>> * remote.c (remote_get_tracepoint_status): Delete addrbuf
>> local variable. Avoid use of sprintf_vma.
> Lucky me I didn't delete the patch before David called me on it!
>
Heh, I sit down from around-the-house tasks thinking to commit my fix,
and Joel has it in hand already! There is one tweak I would suggest:
- sprintf_vma (addrbuf, loc->address);
- sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target, addrbuf);
+ sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target,
+ phex_nz (loc->address,
+ gdbarch_addr_bit (target_gdbarch) / 8));
Just use phex_nz (loc->address, 0) here, its builtin sizeof calculation should be satisfactory.
Stan
next prev parent reply other threads:[~2011-11-26 23:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 19:39 [PATCH] Fix build on sparc David Miller
2011-11-26 20:14 ` [PATCH] Fix build on sparc (remote.c/tracepoints) Joel Brobecker
2011-11-26 20:32 ` David Miller
2011-11-26 20:51 ` Joel Brobecker
2011-11-26 23:42 ` Stan Shebs [this message]
2011-11-27 17:44 ` Joel Brobecker
2011-11-26 20:48 ` [PATCH] Fix build on sparc Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED17954.7070602@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox