From: Joel Brobecker <brobecker@adacore.com>
To: David Miller <davem@davemloft.net>, stan@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix build on sparc (remote.c/tracepoints)
Date: Sat, 26 Nov 2011 20:51:00 -0000 [thread overview]
Message-ID: <20111126205107.GB24943@adacore.com> (raw)
In-Reply-To: <20111126201404.GA24943@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
> gdb/ChangeLog:
>
> * remote.c (remote_get_tracepoint_status): Delete addrbuf
> local variable. Avoid use of sprintf_vma.
Lucky me I didn't delete the patch before David called me on it!
--
Joel
[-- Attachment #2: remote.c.diff --]
[-- Type: text/x-diff, Size: 1368 bytes --]
diff --git a/gdb/remote.c b/gdb/remote.c
index 8fa5c1a..21561e5 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -10219,7 +10219,6 @@ remote_get_tracepoint_status (struct breakpoint *bp,
struct uploaded_tp *utp)
{
struct remote_state *rs = get_remote_state ();
- char addrbuf[40];
char *reply;
struct bp_location *loc;
struct tracepoint *tp = (struct tracepoint *) bp;
@@ -10234,8 +10233,9 @@ remote_get_tracepoint_status (struct breakpoint *bp,
any status. */
if (tp->number_on_target == 0)
continue;
- sprintf_vma (addrbuf, loc->address);
- sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target, addrbuf);
+ sprintf (rs->buf, "qTP:%x:%s", tp->number_on_target,
+ phex_nz (loc->address,
+ gdbarch_addr_bit (target_gdbarch) / 8));
putpkt (rs->buf);
reply = remote_get_noisy_reply (&target_buf, &target_buf_size);
if (reply && *reply)
@@ -10249,8 +10249,7 @@ remote_get_tracepoint_status (struct breakpoint *bp,
{
utp->hit_count = 0;
utp->traceframe_usage = 0;
- sprintf_vma (addrbuf, (long unsigned int) utp->addr);
- sprintf (rs->buf, "qTP:%x:%s", utp->number, addrbuf);
+ sprintf (rs->buf, "qTP:%x:%s", utp->number, phex_nz (utp->addr, 0));
putpkt (rs->buf);
reply = remote_get_noisy_reply (&target_buf, &target_buf_size);
if (reply && *reply)
next prev parent reply other threads:[~2011-11-26 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-26 19:39 [PATCH] Fix build on sparc David Miller
2011-11-26 20:14 ` [PATCH] Fix build on sparc (remote.c/tracepoints) Joel Brobecker
2011-11-26 20:32 ` David Miller
2011-11-26 20:51 ` Joel Brobecker [this message]
2011-11-26 23:42 ` Stan Shebs
2011-11-27 17:44 ` Joel Brobecker
2011-11-26 20:48 ` [PATCH] Fix build on sparc Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111126205107.GB24943@adacore.com \
--to=brobecker@adacore.com \
--cc=davem@davemloft.net \
--cc=gdb-patches@sourceware.org \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox