From: Stan Shebs <stanshebs@earthlink.net>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] MIPS/gdbserver: Fix $f9 access
Date: Thu, 17 Nov 2011 20:39:00 -0000 [thread overview]
Message-ID: <4EC570F2.90302@earthlink.net> (raw)
In-Reply-To: <alpine.DEB.1.10.1111172014020.4191@tp.orcam.me.uk>
On 11/17/11 12:32 PM, Maciej W. Rozycki wrote:
> Hi,
>
> The following change fixes a problem where $f8 is accessed whenever $f9
> is requested. The bug has always been there, since MIPS support was added
> back in 2002. I guess nobody uses gdbserver with MIPS FPU, oh well...
Probably truer than we would like to think. :-)
>
> OK to apply?
Yep, looks fine.
It would be cool to have a testsuite case that exercises this, but let's
be honest, that's more work than it would be worth.
Stan
>
> 2011-11-17 Maciej W. Rozycki<macro@codesourcery.com>
>
> gdb/gdbserver/
> * linux-mips-low.c (mips_regmap): Correct the index of $f9.
>
> Maciej
>
> gdb-gdbserver-linux-mips-fpr-fix.diff
> Index: gdb-fsf-trunk-quilt/gdb/gdbserver/linux-mips-low.c
> ===================================================================
> --- gdb-fsf-trunk-quilt.orig/gdb/gdbserver/linux-mips-low.c 2011-11-17 20:10:51.000000000 +0000
> +++ gdb-fsf-trunk-quilt/gdb/gdbserver/linux-mips-low.c 2011-11-17 20:11:44.995624756 +0000
> @@ -63,7 +63,7 @@ static int mips_regmap[] = {
>
> FPR_BASE, FPR_BASE + 1, FPR_BASE + 2, FPR_BASE + 3,
> FPR_BASE + 4, FPR_BASE + 5, FPR_BASE + 6, FPR_BASE + 7,
> - FPR_BASE + 8, FPR_BASE + 8, FPR_BASE + 10, FPR_BASE + 11,
> + FPR_BASE + 8, FPR_BASE + 9, FPR_BASE + 10, FPR_BASE + 11,
> FPR_BASE + 12, FPR_BASE + 13, FPR_BASE + 14, FPR_BASE + 15,
> FPR_BASE + 16, FPR_BASE + 17, FPR_BASE + 18, FPR_BASE + 19,
> FPR_BASE + 20, FPR_BASE + 21, FPR_BASE + 22, FPR_BASE + 23,
>
next prev parent reply other threads:[~2011-11-17 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 20:32 Maciej W. Rozycki
2011-11-17 20:39 ` Stan Shebs [this message]
2012-02-24 16:28 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC570F2.90302@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox