From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26866 invoked by alias); 17 Nov 2011 20:39:30 -0000 Received: (qmail 26853 invoked by uid 22791); 17 Nov 2011 20:39:29 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from elasmtp-masked.atl.sa.earthlink.net (HELO elasmtp-masked.atl.sa.earthlink.net) (209.86.89.68) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Nov 2011 20:39:16 +0000 Received: from [70.170.59.51] (helo=macbook2.local) by elasmtp-masked.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1RR8js-0007gi-76 for gdb-patches@sourceware.org; Thu, 17 Nov 2011 15:39:16 -0500 Message-ID: <4EC570F2.90302@earthlink.net> Date: Thu, 17 Nov 2011 20:39:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] MIPS/gdbserver: Fix $f9 access References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da9406ab1f152f3a4743b9b04771d8a966b53350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00485.txt.bz2 On 11/17/11 12:32 PM, Maciej W. Rozycki wrote: > Hi, > > The following change fixes a problem where $f8 is accessed whenever $f9 > is requested. The bug has always been there, since MIPS support was added > back in 2002. I guess nobody uses gdbserver with MIPS FPU, oh well... Probably truer than we would like to think. :-) > > OK to apply? Yep, looks fine. It would be cool to have a testsuite case that exercises this, but let's be honest, that's more work than it would be worth. Stan > > 2011-11-17 Maciej W. Rozycki > > gdb/gdbserver/ > * linux-mips-low.c (mips_regmap): Correct the index of $f9. > > Maciej > > gdb-gdbserver-linux-mips-fpr-fix.diff > Index: gdb-fsf-trunk-quilt/gdb/gdbserver/linux-mips-low.c > =================================================================== > --- gdb-fsf-trunk-quilt.orig/gdb/gdbserver/linux-mips-low.c 2011-11-17 20:10:51.000000000 +0000 > +++ gdb-fsf-trunk-quilt/gdb/gdbserver/linux-mips-low.c 2011-11-17 20:11:44.995624756 +0000 > @@ -63,7 +63,7 @@ static int mips_regmap[] = { > > FPR_BASE, FPR_BASE + 1, FPR_BASE + 2, FPR_BASE + 3, > FPR_BASE + 4, FPR_BASE + 5, FPR_BASE + 6, FPR_BASE + 7, > - FPR_BASE + 8, FPR_BASE + 8, FPR_BASE + 10, FPR_BASE + 11, > + FPR_BASE + 8, FPR_BASE + 9, FPR_BASE + 10, FPR_BASE + 11, > FPR_BASE + 12, FPR_BASE + 13, FPR_BASE + 14, FPR_BASE + 15, > FPR_BASE + 16, FPR_BASE + 17, FPR_BASE + 18, FPR_BASE + 19, > FPR_BASE + 20, FPR_BASE + 21, FPR_BASE + 22, FPR_BASE + 23, >