Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Fix problems related to Mingw/DJGPP file names containing colons
Date: Fri, 12 Aug 2011 17:00:00 -0000	[thread overview]
Message-ID: <4E455C19.2010307@redhat.com> (raw)
In-Reply-To: <004901cc5907$85006320$8f012960$@muller@ics-cnrs.unistra.fr>

On 08/12/2011 08:50 AM, Pierre Muller wrote:
>    I first tried to add double-quotes around the file name,
> but this was not enough... I suspect that the other changes
> below that I had to add are just errors in the current implementation...
>    See below for submitted patch.

I remember this bug. I believe I introduced this with one of my many 
hackings on linespec.c. This is gdb/12843, about which I'd nearly forgotten.

I was going to work on this patch after 12266, but that bug has lasted 
much longer than I expected.

Unfortunately, your patch causes several test suite regressions for me 
(as it is right now):

+FAIL: gdb.base/break.exp: breakpoint quoted function (got interactive 
prompt)
+FAIL: gdb.base/break.exp: breakpoint info
+FAIL: gdb.base/break.exp: info break 2 4 6
+FAIL: gdb.base/break.exp: info break 3-5
+FAIL: gdb.base/break.exp: check disable with history values
+FAIL: gdb.base/break.exp: check disable with convenience values
+FAIL: gdb.base/break.exp: run until quoted breakpoint
+FAIL: gdb.base/break.exp: run until file:linenum breakpoint (the 
program exited)
+FAIL: gdb.base/break.exp: step onto breakpoint (the program is no 
longer running)
+FAIL: gdb.base/break.exp: continue to breakpoint at } (the program is 
no longer running)
+FAIL: gdb.base/sepdebug.exp: breakpoint quoted function (got 
interactive prompt)
+FAIL: gdb.base/sepdebug.exp: breakpoint info
+FAIL: gdb.base/sepdebug.exp: run until quoted breakpoint
+FAIL: gdb.base/sepdebug.exp: run until file:linenum breakpoint (the 
program exited)
+FAIL: gdb.base/sepdebug.exp: step onto breakpoint (the program is no 
+FAIL: gdb.cp/cmpd-minsyms.exp: setting breakpoint at "int 
GDB<char>::even_harder<int>(char)"
+FAIL: gdb.cp/overload.exp: list overloaded function with function ptr 
args - quotes around argument

If it's okay with you, I'd like to take this bug myself. I will drop 
everything and work on it immediately.

Keith


  reply	other threads:[~2011-08-12 17:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-12 15:50 Pierre Muller
2011-08-12 17:00 ` Keith Seitz [this message]
     [not found] <004901cc5907$85006320$8f012960$%muller@ics-cnrs.unistra.fr>
2011-08-12 17:17 ` Eli Zaretskii
2011-08-12 17:25   ` Tom Tromey
2011-08-12 17:47     ` Eli Zaretskii
2011-08-13 10:11       ` Pierre Muller
     [not found]       ` <003c01cc59a1$49cc1520$dd643f60$%muller@ics-cnrs.unistra.fr>
2011-08-13 10:50         ` Eli Zaretskii
2011-08-13 20:42           ` Pierre Muller
2011-08-13 20:51             ` DJ Delorie
2011-08-13 21:26             ` Mark Kettenis
2011-08-15 19:29               ` Tom Tromey
     [not found]           ` <28604.9419818029$1313268187@news.gmane.org>
2011-08-15 19:21             ` Tom Tromey
     [not found] <7973.24406817115$1313164244@news.gmane.org>
2011-08-13  1:20 ` asmwarrior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E455C19.2010307@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox