From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15599 invoked by alias); 12 Aug 2011 17:00:32 -0000 Received: (qmail 15587 invoked by uid 22791); 12 Aug 2011 17:00:32 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Aug 2011 17:00:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7CH0CMV025671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 12 Aug 2011 13:00:13 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7CH09f3014313 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 12 Aug 2011 13:00:11 -0400 Message-ID: <4E455C19.2010307@redhat.com> Date: Fri, 12 Aug 2011 17:00:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: Pierre Muller CC: gdb-patches@sourceware.org Subject: Re: [RFC] Fix problems related to Mingw/DJGPP file names containing colons References: <004901cc5907$85006320$8f012960$@muller@ics-cnrs.unistra.fr> In-Reply-To: <004901cc5907$85006320$8f012960$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00253.txt.bz2 On 08/12/2011 08:50 AM, Pierre Muller wrote: > I first tried to add double-quotes around the file name, > but this was not enough... I suspect that the other changes > below that I had to add are just errors in the current implementation... > See below for submitted patch. I remember this bug. I believe I introduced this with one of my many hackings on linespec.c. This is gdb/12843, about which I'd nearly forgotten. I was going to work on this patch after 12266, but that bug has lasted much longer than I expected. Unfortunately, your patch causes several test suite regressions for me (as it is right now): +FAIL: gdb.base/break.exp: breakpoint quoted function (got interactive prompt) +FAIL: gdb.base/break.exp: breakpoint info +FAIL: gdb.base/break.exp: info break 2 4 6 +FAIL: gdb.base/break.exp: info break 3-5 +FAIL: gdb.base/break.exp: check disable with history values +FAIL: gdb.base/break.exp: check disable with convenience values +FAIL: gdb.base/break.exp: run until quoted breakpoint +FAIL: gdb.base/break.exp: run until file:linenum breakpoint (the program exited) +FAIL: gdb.base/break.exp: step onto breakpoint (the program is no longer running) +FAIL: gdb.base/break.exp: continue to breakpoint at } (the program is no longer running) +FAIL: gdb.base/sepdebug.exp: breakpoint quoted function (got interactive prompt) +FAIL: gdb.base/sepdebug.exp: breakpoint info +FAIL: gdb.base/sepdebug.exp: run until quoted breakpoint +FAIL: gdb.base/sepdebug.exp: run until file:linenum breakpoint (the program exited) +FAIL: gdb.base/sepdebug.exp: step onto breakpoint (the program is no +FAIL: gdb.cp/cmpd-minsyms.exp: setting breakpoint at "int GDB::even_harder(char)" +FAIL: gdb.cp/overload.exp: list overloaded function with function ptr args - quotes around argument If it's okay with you, I'd like to take this bug myself. I will drop everything and work on it immediately. Keith