Re: [PATCH] gdb.base/commands.exp: fix racy test (PR testsuite/12649)

[Marek Polacek <mpolacek@redhat.com>]

On 04/13/2011 11:20 AM, Jan Kratochvil wrote:
> I would prefer one re-post before the approval.

Sure!  Thanks for review.  Here's amended version (if there's still anything that
could be improved, just tell me):

2011-04-13  Marek Polacek  <mpolacek@redhat.com>

        * gdb.base/commands.exp (redefine_backtrace_test): Fix race. 
        New testcase `expect response to define backtrace'.  Also remove
        redundant `default' block.

Signed-off-by: Marek Polacek <mpolacek@redhat.com>
---
 gdb/testsuite/gdb.base/commands.exp |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/gdb/testsuite/gdb.base/commands.exp b/gdb/testsuite/gdb.base/commands.exp
index 3bff053..a0ac25b 100644
--- a/gdb/testsuite/gdb.base/commands.exp
+++ b/gdb/testsuite/gdb.base/commands.exp
@@ -704,18 +704,17 @@ proc redefine_backtrace_test {} {
     global gdb_prompt
 
     gdb_test_multiple "define backtrace" "define backtrace" {
-	-re "Really redefine built-in.*$" {
-	    send_gdb "y\n"
-	    exp_continue
+	-re "Really redefine built-in command \"backtrace\"\\? \\(y or n\\) $"  {
+	    pass "define backtrace"
 	}
+    }
 
-	-re "End with"  {
-	    pass "define backtrace in redefine_backtrace_test"
-	}
-        default {
-	    fail "(timeout or eof) define backtrace in redefine_backtrace_test"
+    gdb_test_multiple "y" "expect response to define backtrace" {
+	-re "End with a line saying just \"end\"\\.\r\n>$"  {
+	    pass "expect response to define backtrace"
 	}
     }
+
     gdb_test "echo hibob\\n\nend" \
 	    "" \
 	    "enter commands in redefine_backtrace_test"
-- 
1.7.3.4