From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4159 invoked by alias); 13 Apr 2011 15:36:41 -0000 Received: (qmail 4028 invoked by uid 22791); 13 Apr 2011 15:36:40 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 15:36:27 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3DFaRnW013978 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Apr 2011 11:36:27 -0400 Received: from dhcp-25-89.brq.redhat.com (vpn-9-80.rdu.redhat.com [10.11.9.80]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3DFaQA2028820; Wed, 13 Apr 2011 11:36:26 -0400 Message-ID: <4DA5C2F9.908@redhat.com> Date: Wed, 13 Apr 2011 15:36:00 -0000 From: Marek Polacek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100827 Red Hat Thunderbird/3.1.3 MIME-Version: 1.0 To: Jan Kratochvil CC: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.base/commands.exp: fix racy test (PR testsuite/12649) References: <4DA55797.5090800@redhat.com> <20110413092029.GA19366@host1.jankratochvil.net> In-Reply-To: <20110413092029.GA19366@host1.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00186.txt.bz2 On 04/13/2011 11:20 AM, Jan Kratochvil wrote: > I would prefer one re-post before the approval. Sure! Thanks for review. Here's amended version (if there's still anything that could be improved, just tell me): 2011-04-13 Marek Polacek * gdb.base/commands.exp (redefine_backtrace_test): Fix race. New testcase `expect response to define backtrace'. Also remove redundant `default' block. Signed-off-by: Marek Polacek --- gdb/testsuite/gdb.base/commands.exp | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/gdb/testsuite/gdb.base/commands.exp b/gdb/testsuite/gdb.base/commands.exp index 3bff053..a0ac25b 100644 --- a/gdb/testsuite/gdb.base/commands.exp +++ b/gdb/testsuite/gdb.base/commands.exp @@ -704,18 +704,17 @@ proc redefine_backtrace_test {} { global gdb_prompt gdb_test_multiple "define backtrace" "define backtrace" { - -re "Really redefine built-in.*$" { - send_gdb "y\n" - exp_continue + -re "Really redefine built-in command \"backtrace\"\\? \\(y or n\\) $" { + pass "define backtrace" } + } - -re "End with" { - pass "define backtrace in redefine_backtrace_test" - } - default { - fail "(timeout or eof) define backtrace in redefine_backtrace_test" + gdb_test_multiple "y" "expect response to define backtrace" { + -re "End with a line saying just \"end\"\\.\r\n>$" { + pass "expect response to define backtrace" } } + gdb_test "echo hibob\\n\nend" \ "" \ "enter commands in redefine_backtrace_test" -- 1.7.3.4