Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [patch] Cleanup redundant statements in arm-tdep.c:copy_ldr_str_ldrb_strb
Date: Fri, 11 Mar 2011 06:45:00 -0000	[thread overview]
Message-ID: <4D79C100.5080605@codesourcery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

On 02/26/2011 09:53 PM, Yao Qi wrote:
>>> >> +      RECORD_ARM_MODE_INSN (6, 0x00); /* breakpoint location.  */
>>> >> +      RECORD_ARM_MODE_INSN (7, 0x00); /* scratch space.  */
>> >
>> > This reminds me: after your latest patch in that area, we do not
>> > actually use any scratch space in the instruction stream any more,
>> > so this could be removed ...
>> >
> Oh, Yes.  I'll remove it by another patch.
>

As my recent patch "[patch] Fix PR tdep/12352: Handle str pc, [Rd, #imm]
in displaced stepping"[1] applied, scratch space is not used, and two
statements are redundant.  This patch is to remove them.

[1] http://sourceware.org/ml/gdb-patches/2011-02/msg00315.html
-- 
Yao (齐尧)

[-- Attachment #2: cleanup-arm-0311.patch --]
[-- Type: text/x-patch, Size: 492 bytes --]

gdb/
	* arm-tdep.c (copy_ldr_str_ldrb_strb): Remove redundant statements.

diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 7796176..6e5f2ab 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -6003,9 +6003,6 @@ copy_ldr_str_ldrb_strb (struct gdbarch *gdbarch, uint32_t insn,
       else
 	dsc->modinsn[5] = (insn & 0xfff00ff0) | 0x20003;
 
-      dsc->modinsn[6] = 0x0;  /* breakpoint location.  */
-      dsc->modinsn[7] = 0x0;  /* scratch space.  */
-
       dsc->numinsns = 6;
     }
 

             reply	other threads:[~2011-03-11  6:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11  6:45 Yao Qi [this message]
2011-03-11 15:59 ` Ulrich Weigand
2011-03-11 16:06   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D79C100.5080605@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox