From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28811 invoked by alias); 11 Mar 2011 06:28:31 -0000 Received: (qmail 28802 invoked by uid 22791); 11 Mar 2011 06:28:30 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 06:28:24 +0000 Received: (qmail 2529 invoked from network); 11 Mar 2011 06:28:21 -0000 Received: from unknown (HELO ?192.168.0.102?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Mar 2011 06:28:21 -0000 Message-ID: <4D79C100.5080605@codesourcery.com> Date: Fri, 11 Mar 2011 06:45:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [patch] Cleanup redundant statements in arm-tdep.c:copy_ldr_str_ldrb_strb Content-Type: multipart/mixed; boundary="------------040403090402000109090303" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00651.txt.bz2 This is a multi-part message in MIME format. --------------040403090402000109090303 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-length: 695 On 02/26/2011 09:53 PM, Yao Qi wrote: >>> >> + RECORD_ARM_MODE_INSN (6, 0x00); /* breakpoint location. */ >>> >> + RECORD_ARM_MODE_INSN (7, 0x00); /* scratch space. */ >> > >> > This reminds me: after your latest patch in that area, we do not >> > actually use any scratch space in the instruction stream any more, >> > so this could be removed ... >> > > Oh, Yes. I'll remove it by another patch. > As my recent patch "[patch] Fix PR tdep/12352: Handle str pc, [Rd, #imm] in displaced stepping"[1] applied, scratch space is not used, and two statements are redundant. This patch is to remove them. [1] http://sourceware.org/ml/gdb-patches/2011-02/msg00315.html -- Yao (齐尧) --------------040403090402000109090303 Content-Type: text/x-patch; name="cleanup-arm-0311.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="cleanup-arm-0311.patch" Content-length: 492 gdb/ * arm-tdep.c (copy_ldr_str_ldrb_strb): Remove redundant statements. diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index 7796176..6e5f2ab 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -6003,9 +6003,6 @@ copy_ldr_str_ldrb_strb (struct gdbarch *gdbarch, uint32_t insn, else dsc->modinsn[5] = (insn & 0xfff00ff0) | 0x20003; - dsc->modinsn[6] = 0x0; /* breakpoint location. */ - dsc->modinsn[7] = 0x0; /* scratch space. */ - dsc->numinsns = 6; } --------------040403090402000109090303--