From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] completer.c (expression_completer): Stop memory leak.
Date: Wed, 09 Mar 2011 20:07:00 -0000 [thread overview]
Message-ID: <4D77CDD6.7010700@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 97 bytes --]
In this case, it is possible for fieldname to be allocated before an
exception is thrown.
OK?
[-- Attachment #2: completer.txt --]
[-- Type: text/plain, Size: 678 bytes --]
2011-03-09 Michael Snyder <msnyder@msnyder-server.eng.vmware.com>
* completer.c (expression_completer): Stop memory leak.
Index: completer.c
===================================================================
RCS file: /cvs/src/src/gdb/completer.c,v
retrieving revision 1.44
diff -u -p -r1.44 completer.c
--- completer.c 26 Feb 2011 02:07:07 -0000 1.44
+++ completer.c 9 Mar 2011 18:56:24 -0000
@@ -455,7 +455,10 @@ expression_completer (struct cmd_list_el
type = parse_field_expression (text, &fieldname);
}
if (except.reason < 0)
- return NULL;
+ {
+ free (fieldname);
+ return NULL;
+ }
if (fieldname && type)
{
for (;;)
next reply other threads:[~2011-03-09 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 20:07 Michael Snyder [this message]
2011-03-09 20:29 ` Pedro Alves
2011-03-09 23:58 ` Michael Snyder
2011-03-10 0:14 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D77CDD6.7010700@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox