From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9601 invoked by alias); 9 Mar 2011 18:58:37 -0000 Received: (qmail 9592 invoked by uid 22791); 9 Mar 2011 18:58:37 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 18:58:32 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 4E7BA54012 for ; Wed, 9 Mar 2011 10:58:31 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 4661BCD965 for ; Wed, 9 Mar 2011 10:58:31 -0800 (PST) Message-ID: <4D77CDD6.7010700@vmware.com> Date: Wed, 09 Mar 2011 20:07:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] completer.c (expression_completer): Stop memory leak. Content-Type: multipart/mixed; boundary="------------020002060100000201040506" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00619.txt.bz2 This is a multi-part message in MIME format. --------------020002060100000201040506 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 97 In this case, it is possible for fieldname to be allocated before an exception is thrown. OK? --------------020002060100000201040506 Content-Type: text/plain; name="completer.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="completer.txt" Content-length: 678 2011-03-09 Michael Snyder * completer.c (expression_completer): Stop memory leak. Index: completer.c =================================================================== RCS file: /cvs/src/src/gdb/completer.c,v retrieving revision 1.44 diff -u -p -r1.44 completer.c --- completer.c 26 Feb 2011 02:07:07 -0000 1.44 +++ completer.c 9 Mar 2011 18:56:24 -0000 @@ -455,7 +455,10 @@ expression_completer (struct cmd_list_el type = parse_field_expression (text, &fieldname); } if (except.reason < 0) - return NULL; + { + free (fieldname); + return NULL; + } if (fieldname && type) { for (;;) --------------020002060100000201040506--