Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Maxim Grigoriev <maxim@tensilica.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [commit] Fix Xtensa-specific bug in MI command
Date: Wed, 09 Mar 2011 03:46:00 -0000	[thread overview]
Message-ID: <4D76EC10.3000008@tensilica.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 70 bytes --]

Fix Xtensa-specific bug in MI command -data-list-changed-registers.



[-- Attachment #2: MIregs.diff --]
[-- Type: text/plain, Size: 1550 bytes --]

2011-03-08  Maxim Grigoriev  <maxim2405@gmail.com>

	* xtensa-tdep.c (xtensa_register_reggroup_p): Count in all registers
	while executing MI command -data-list-changed-registers.

Index: gdb/xtensa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/xtensa-tdep.c,v
retrieving revision 1.49
diff -u -r1.49 xtensa-tdep.c
--- gdb/xtensa-tdep.c	9 Mar 2011 02:25:12 -0000	1.49
+++ gdb/xtensa-tdep.c	9 Mar 2011 02:51:35 -0000
@@ -813,6 +813,11 @@
   xtensa_register_group_t rg = reg->group;
   int cp_number;
 
+  if (group == save_reggroup)
+    /* Every single register should be included into the list of registers
+       to be watched for changes while using -data-list-changed-registers.  */
+    return 1;
+
   /* First, skip registers that are not visible to this target
      (unknown and unmapped registers when not using ISS).  */
 
@@ -828,13 +833,11 @@
     return rg & xtRegisterGroupFloat;
   if (group == general_reggroup)
     return rg & xtRegisterGroupGeneral;
-  if (group == float_reggroup)
-    return rg & xtRegisterGroupFloat;
   if (group == system_reggroup)
     return rg & xtRegisterGroupState;
   if (group == vector_reggroup || group == xtensa_vectra_reggroup)
     return rg & xtRegisterGroupVectra;
-  if (group == save_reggroup || group == restore_reggroup)
+  if (group == restore_reggroup)
     return (regnum < gdbarch_num_regs (gdbarch)
 	    && (reg->flags & SAVE_REST_FLAGS) == SAVE_REST_VALID);
   if ((cp_number = xtensa_coprocessor_register_group (group)) >= 0)

             reply	other threads:[~2011-03-09  2:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09  3:46 Maxim Grigoriev [this message]
2011-03-09  4:26 ` Joel Brobecker
2011-03-09 18:38   ` Maxim Grigoriev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D76EC10.3000008@tensilica.com \
    --to=maxim@tensilica.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox