From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31417 invoked by alias); 9 Mar 2011 02:55:36 -0000 Received: (qmail 31408 invoked by uid 22791); 9 Mar 2011 02:55:35 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mailgw.tensilica.com (HELO mailgw.tensilica.com) (65.119.96.134) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 02:55:31 +0000 Received: from localhost (unknown [127.0.0.1]) by mailgw.tensilica.com (Postfix) with ESMTP id EF1161160554 for ; Wed, 9 Mar 2011 02:55:29 +0000 (UTC) Received: from mailgw.tensilica.com ([127.0.0.1]) by localhost (mailgw.tensilica.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 26477-05 for ; Tue, 8 Mar 2011 18:55:29 -0800 (PST) Received: from mail.tensilica.com (mail.tensilica.com [192.168.15.138]) by mailgw.tensilica.com (Postfix) with ESMTP id C99E91160552 for ; Tue, 8 Mar 2011 18:55:13 -0800 (PST) Received: from [192.168.11.68] (192.168.11.68) by mail.tensilica.com (192.168.15.138) with Microsoft SMTP Server id 8.2.254.0; Tue, 8 Mar 2011 18:55:13 -0800 Message-ID: <4D76EC10.3000008@tensilica.com> Date: Wed, 09 Mar 2011 03:46:00 -0000 From: Maxim Grigoriev User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.10 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [commit] Fix Xtensa-specific bug in MI command Content-Type: multipart/mixed; boundary="------------060208080000030103060802" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00578.txt.bz2 --------------060208080000030103060802 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 70 Fix Xtensa-specific bug in MI command -data-list-changed-registers. --------------060208080000030103060802 Content-Type: text/plain; name="MIregs.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="MIregs.diff" Content-length: 1550 2011-03-08 Maxim Grigoriev * xtensa-tdep.c (xtensa_register_reggroup_p): Count in all registers while executing MI command -data-list-changed-registers. Index: gdb/xtensa-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/xtensa-tdep.c,v retrieving revision 1.49 diff -u -r1.49 xtensa-tdep.c --- gdb/xtensa-tdep.c 9 Mar 2011 02:25:12 -0000 1.49 +++ gdb/xtensa-tdep.c 9 Mar 2011 02:51:35 -0000 @@ -813,6 +813,11 @@ xtensa_register_group_t rg = reg->group; int cp_number; + if (group == save_reggroup) + /* Every single register should be included into the list of registers + to be watched for changes while using -data-list-changed-registers. */ + return 1; + /* First, skip registers that are not visible to this target (unknown and unmapped registers when not using ISS). */ @@ -828,13 +833,11 @@ return rg & xtRegisterGroupFloat; if (group == general_reggroup) return rg & xtRegisterGroupGeneral; - if (group == float_reggroup) - return rg & xtRegisterGroupFloat; if (group == system_reggroup) return rg & xtRegisterGroupState; if (group == vector_reggroup || group == xtensa_vectra_reggroup) return rg & xtRegisterGroupVectra; - if (group == save_reggroup || group == restore_reggroup) + if (group == restore_reggroup) return (regnum < gdbarch_num_regs (gdbarch) && (reg->flags & SAVE_REST_FLAGS) == SAVE_REST_VALID); if ((cp_number = xtensa_coprocessor_register_group (group)) >= 0) --------------060208080000030103060802--