From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] dwarf2loc.c, loclist_read_variable, Assert frame not null
Date: Fri, 04 Mar 2011 22:37:00 -0000 [thread overview]
Message-ID: <4D7169A9.4000207@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
Now, I've heard a rumor that frame-infos can never be null.
If that's true, then instead of this patch, we should just
delete the earlier check for null.
OK?
[-- Attachment #2: null5.txt --]
[-- Type: text/plain, Size: 790 bytes --]
2011-03-04 Michael Snyder <msnyder@vmware.com>
* dwarf2loc.c (loclist_read_variable): Assert frame not null.
Index: dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.110
diff -u -p -u -p -r1.110 dwarf2loc.c
--- dwarf2loc.c 27 Feb 2011 00:01:12 -0000 1.110
+++ dwarf2loc.c 4 Mar 2011 22:34:24 -0000
@@ -2687,8 +2687,11 @@ loclist_read_variable (struct symbol *sy
set_value_optimized_out (val, 1);
}
else
- val = dwarf2_evaluate_loc_desc (SYMBOL_TYPE (symbol), frame, data, size,
- dlbaton->per_cu);
+ {
+ gdb_asert (frame);
+ val = dwarf2_evaluate_loc_desc (SYMBOL_TYPE (symbol), frame,
+ data, size, dlbaton->per_cu);
+ }
return val;
}
next reply other threads:[~2011-03-04 22:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 22:37 Michael Snyder [this message]
2011-03-04 23:34 ` Ulrich Weigand
2011-03-05 0:00 ` Pedro Alves
2011-03-05 0:12 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7169A9.4000207@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox