From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21425 invoked by alias); 4 Mar 2011 22:37:36 -0000 Received: (qmail 21373 invoked by uid 22791); 4 Mar 2011 22:37:35 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,TW_DL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 22:37:31 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id F0254E003 for ; Fri, 4 Mar 2011 14:37:29 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id E3705CD971 for ; Fri, 4 Mar 2011 14:37:29 -0800 (PST) Message-ID: <4D7169A9.4000207@vmware.com> Date: Fri, 04 Mar 2011 22:37:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] dwarf2loc.c, loclist_read_variable, Assert frame not null Content-Type: multipart/mixed; boundary="------------050703080605000902050201" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00337.txt.bz2 This is a multi-part message in MIME format. --------------050703080605000902050201 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 162 Now, I've heard a rumor that frame-infos can never be null. If that's true, then instead of this patch, we should just delete the earlier check for null. OK? --------------050703080605000902050201 Content-Type: text/plain; name="null5.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="null5.txt" Content-length: 790 2011-03-04 Michael Snyder * dwarf2loc.c (loclist_read_variable): Assert frame not null. Index: dwarf2loc.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2loc.c,v retrieving revision 1.110 diff -u -p -u -p -r1.110 dwarf2loc.c --- dwarf2loc.c 27 Feb 2011 00:01:12 -0000 1.110 +++ dwarf2loc.c 4 Mar 2011 22:34:24 -0000 @@ -2687,8 +2687,11 @@ loclist_read_variable (struct symbol *sy set_value_optimized_out (val, 1); } else - val = dwarf2_evaluate_loc_desc (SYMBOL_TYPE (symbol), frame, data, size, - dlbaton->per_cu); + { + gdb_asert (frame); + val = dwarf2_evaluate_loc_desc (SYMBOL_TYPE (symbol), frame, + data, size, dlbaton->per_cu); + } return val; } --------------050703080605000902050201--