Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] remote.c, putpkt_binary, document that case statement falls thru
Date: Fri, 04 Mar 2011 19:04:00 -0000	[thread overview]
Message-ID: <4D7137A2.6090105@vmware.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

This has been working, so it must be correct...

OK?


[-- Attachment #2: fallthru9.txt --]
[-- Type: text/plain, Size: 624 bytes --]

2011-03-04  Michael Snyder  <msnyder@vmware.com>

	* remote.c (putpkt_binary): Document that case stmt falls through.

Index: remote.c
===================================================================
RCS file: /cvs/src/src/gdb/remote.c,v
retrieving revision 1.436
diff -u -p -u -p -r1.436 remote.c
--- remote.c	1 Mar 2011 00:34:27 -0000	1.436
+++ remote.c	4 Mar 2011 19:01:30 -0000
@@ -6848,6 +6848,7 @@ putpkt_binary (char *buf, int cnt)
 	    case '-':
 	      if (remote_debug)
 		fprintf_unfiltered (gdb_stdlog, "Nak\n");
+	      /* FALLTHROUGH */
 	    case SERIAL_TIMEOUT:
 	      tcount++;
 	      if (tcount > 3)

             reply	other threads:[~2011-03-04 19:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 19:04 Michael Snyder [this message]
2011-03-04 19:29 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7137A2.6090105@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox