From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4748 invoked by alias); 4 Mar 2011 19:04:09 -0000 Received: (qmail 4739 invoked by uid 22791); 4 Mar 2011 19:04:08 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,TW_TM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 19:04:04 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 4686A1304C for ; Fri, 4 Mar 2011 11:04:03 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 3BA24CA022 for ; Fri, 4 Mar 2011 11:04:03 -0800 (PST) Message-ID: <4D7137A2.6090105@vmware.com> Date: Fri, 04 Mar 2011 19:04:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] remote.c, putpkt_binary, document that case statement falls thru Content-Type: multipart/mixed; boundary="------------040505060902040503040507" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00311.txt.bz2 This is a multi-part message in MIME format. --------------040505060902040503040507 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 54 This has been working, so it must be correct... OK? --------------040505060902040503040507 Content-Type: text/plain; name="fallthru9.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fallthru9.txt" Content-length: 624 2011-03-04 Michael Snyder * remote.c (putpkt_binary): Document that case stmt falls through. Index: remote.c =================================================================== RCS file: /cvs/src/src/gdb/remote.c,v retrieving revision 1.436 diff -u -p -u -p -r1.436 remote.c --- remote.c 1 Mar 2011 00:34:27 -0000 1.436 +++ remote.c 4 Mar 2011 19:01:30 -0000 @@ -6848,6 +6848,7 @@ putpkt_binary (char *buf, int cnt) case '-': if (remote_debug) fprintf_unfiltered (gdb_stdlog, "Nak\n"); + /* FALLTHROUGH */ case SERIAL_TIMEOUT: tcount++; if (tcount > 3) --------------040505060902040503040507--