From: Michael Snyder <msnyder@vmware.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Tristan Gingold <gingold@adacore.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
Date: Fri, 04 Mar 2011 18:27:00 -0000 [thread overview]
Message-ID: <4D712F12.8050808@vmware.com> (raw)
In-Reply-To: <m3r5amu4tz.fsf@fleche.redhat.com>
Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
>
> Michael> Are you sure? There is a path to "goto unknown" from before the
> Michael> call to the alloc function. It might actually be null. Some
> Michael> versions of 'free' don't like that.
>
> This isn't an issue with free any more. Jim Meyering did some research
> into it a while ago and fixed a number of popular free software projects
> to remove the useless test. Here's a page with some interesting data:
>
> http://www.winehq.org/pipermail/wine-patches/2006-October/031544.html
>
> Tom
Thanks for the info.
Checking in without the null pointer test.
How come 'xfree' in gdb/utils.c still checks for null?
next prev parent reply other threads:[~2011-03-04 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 21:20 Michael Snyder
2011-03-03 21:30 ` Jakub Jelinek
2011-03-03 22:00 ` Michael Snyder
2011-03-04 9:34 ` Tristan Gingold
2011-03-04 18:07 ` Michael Snyder
[not found] ` <4D712A5F.1040307__35010.4677411311$1299262072$gmane$org@vmware.com>
2011-03-04 18:19 ` Tom Tromey
2011-03-04 18:27 ` Michael Snyder [this message]
[not found] ` <4D712F12.8050808__11842.7885965959$1299263268$gmane$org@vmware.com>
2011-03-04 18:37 ` Tom Tromey
2011-03-04 18:41 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D712F12.8050808@vmware.com \
--to=msnyder@vmware.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox