From: Jakub Jelinek <jakub@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "dj@redhat.com" <dj@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
Date: Thu, 03 Mar 2011 21:30:00 -0000 [thread overview]
Message-ID: <20110303213008.GY30899@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <4D70061C.10904@vmware.com>
On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote:
> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>
> * libiberty/cplus-dem.c (ada_demangle): Stop memory leak.
> Also fix a one line indent problem.
No libiberty/ in libiberty/ChangeLog.
> @@ -1129,10 +1129,11 @@ ada_demangle (const char *mangled, int o
>
> unknown:
> len0 = strlen (mangled);
> + xfree (demangled);
> demangled = XNEWVEC (char, len0 + 3);
xfree isn't ever used in libiberty/*, use either free, or
XDELETE/XDELETEVEC. In fact, it seems to be defined only in gdb,
making cplus-dem.c dependent on gdb is obviously a wrong thing.
Jakub
next prev parent reply other threads:[~2011-03-03 21:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 21:20 Michael Snyder
2011-03-03 21:30 ` Jakub Jelinek [this message]
2011-03-03 22:00 ` Michael Snyder
2011-03-04 9:34 ` Tristan Gingold
2011-03-04 18:07 ` Michael Snyder
[not found] ` <4D712A5F.1040307__35010.4677411311$1299262072$gmane$org@vmware.com>
2011-03-04 18:19 ` Tom Tromey
2011-03-04 18:27 ` Michael Snyder
[not found] ` <4D712F12.8050808__11842.7885965959$1299263268$gmane$org@vmware.com>
2011-03-04 18:37 ` Tom Tromey
2011-03-04 18:41 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303213008.GY30899@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox