* [RFA] solib.c, reload_shared_libraries_1, close memory leak
@ 2011-03-04 1:09 Michael Snyder
2011-03-04 4:58 ` Joel Brobecker
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2011-03-04 1:09 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 5 bytes --]
OK?
[-- Attachment #2: solib.txt --]
[-- Type: text/plain, Size: 662 bytes --]
2011-03-03 Michael Snyder <msnyder@vmware.com>
* solib.c (reload_shared_libraries_1): Close memory leak.
Index: solib.c
===================================================================
RCS file: /cvs/src/src/gdb/solib.c,v
retrieving revision 1.145
diff -u -p -u -p -r1.145 solib.c
--- solib.c 26 Jan 2011 01:55:19 -0000 1.145
+++ solib.c 4 Mar 2011 01:06:54 -0000
@@ -1326,6 +1326,7 @@ reload_shared_libraries_1 (int from_tty)
SYMFILE_DEFER_BP_RESET | (from_tty ? SYMFILE_VERBOSE : 0);
filename = tilde_expand (so->so_original_name);
+ make_cleanup (xfree, filename);
abfd = solib_bfd_open (filename);
if (abfd != NULL)
{
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] solib.c, reload_shared_libraries_1, close memory leak
2011-03-04 1:09 [RFA] solib.c, reload_shared_libraries_1, close memory leak Michael Snyder
@ 2011-03-04 4:58 ` Joel Brobecker
2011-03-04 18:03 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2011-03-04 4:58 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches
> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>
> * solib.c (reload_shared_libraries_1): Close memory leak.
Looks correct to me!
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] solib.c, reload_shared_libraries_1, close memory leak
2011-03-04 4:58 ` Joel Brobecker
@ 2011-03-04 18:03 ` Michael Snyder
0 siblings, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2011-03-04 18:03 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
Joel Brobecker wrote:
>> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>>
>> * solib.c (reload_shared_libraries_1): Close memory leak.
>
> Looks correct to me!
>
Thanks, committed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-04 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-04 1:09 [RFA] solib.c, reload_shared_libraries_1, close memory leak Michael Snyder
2011-03-04 4:58 ` Joel Brobecker
2011-03-04 18:03 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox