From: Michael Snyder <msnyder@vmware.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>,
Yao Qi <yao@codesourcery.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Fix magic number in arm-tdep.c
Date: Wed, 02 Mar 2011 18:32:00 -0000 [thread overview]
Message-ID: <4D6E8D3A.405@vmware.com> (raw)
In-Reply-To: <m3bp1t2x5m.fsf@fleche.redhat.com>
Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
>
>>>> - nextpc = (rn == 15) ? pc_val + 8
>>>> + nextpc = (rn == ARM_PC_REGNUM) ? pc_val + 8
>>>> : get_frame_register_unsigned (frame, rn);
>>> (? and : should remain in the same column).
>>>
>
> Michael> I don't agree - : is an operator and should be indented by just
> Michael> two spaces. As emacs does by default.
>
> You're supposed to add extra parens to make it line up.
> See the "Formatting" node in the GNU Standards.
>
> Tom
OK, that would suit me. ;-)
next prev parent reply other threads:[~2011-03-02 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 7:10 Yao Qi
2011-03-02 14:12 ` Ulrich Weigand
2011-03-02 18:13 ` Michael Snyder
2011-03-02 18:30 ` Tom Tromey
2011-03-02 18:32 ` Michael Snyder [this message]
2011-03-03 2:20 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6E8D3A.405@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=uweigand@de.ibm.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox